-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers replace math::Vector<3> with matrix::Vector3f #9121
Conversation
e9ccd15
to
1b16459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some whitespace problems, but otherwise good to go.
src/drivers/device/integrator.h
Outdated
@@ -84,7 +84,7 @@ class Integrator | |||
* @param integral_dt Get the dt in us of the current integration (only if reset). | |||
* @return the integral since the last read-reset | |||
*/ | |||
math::Vector<3> get(bool reset, uint64_t &integral_dt); | |||
matrix::Vector3f get(bool reset, uint64_t &integral_dt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: spacing is off now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/drivers/device/integrator.h
Outdated
@@ -95,18 +95,18 @@ class Integrator | |||
* @param filtered_val The integral differentiated by the integration time. | |||
* @return the integral since the last read-reset | |||
*/ | |||
math::Vector<3> get_and_filtered(bool reset, uint64_t &integral_dt, math::Vector<3> &filtered_val); | |||
matrix::Vector3f get_and_filtered(bool reset, uint64_t &integral_dt, matrix::Vector3f &filtered_val); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/drivers/device/integrator.h
Outdated
math::Vector<3> _beta; /**< accumulated coning corrections */ | ||
math::Vector<3> _last_val; /**< previous input */ | ||
math::Vector<3> _last_delta_alpha; /**< integral from previous previous sampling interval */ | ||
matrix::Vector3f _alpha; /**< integrated value before coning corrections are applied */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
1b16459
to
a118047
Compare
No description provided.