airspeed driver: un-advertise differential pressure topic #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
previously approved these changes
Mar 23, 2018
|
There's already a NULL pointer check within uORB. https://github.com/PX4/Firmware/blob/master/src/modules/uORB/uORBDevices.cpp#L473 |
|
@dagar I wanted to avoid people looking at that code and thinking what I'm doing is dangerous. |
|
It's definitely good practice in general. |
|
Once off it doesn't matter, but it's the kind of the thing that starts to add up across an entire codebase. Likewise for checking NULL before calling delete. |
Signed-off-by: Roman <[email protected]>
RomanBapst
force-pushed
the
pr-airspeed-unadvertise
branch
from
37791c7 to
8b553de
Compare
|
@dagar Done |
dagar
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman [email protected]