-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add settling time on sensor start-up #9164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This delays the whole system. Instead it would be appropriate to add functionality to back off in the next call / schedule the following call later.
Would further delaying the first cycle resolve the problem? https://github.com/ASM3/Firmware/blob/79bdf007741750c8a78b56e8c2a0b571d0b3ecff/src/drivers/imu/adis16448/adis16448.cpp#L1358 |
Obviously, this is the purpose. We want to prevent the uc to perform any kind of SPI writing cycle during this epoch, what potentially could mess up the adis16448 registers (happened in very rare cases). If this delay during boot-up sequence is so critical for the system another solution can potentially be figured out. |
BTW, the main purpose of this functionality is to set all units with the default calibration values so that the system can align with a standard configuration. One can decide that it is up to the user to perform this step and then this functionality can be completely removed from the start up sequence. |
79bdf00
to
3665a98
Compare
The restore factory calibration functionality is unnecessary on the boot-up sequence and therefore removed |
@dagar @LorenzMeier To explain a bit: We noticed that the |
Add settling time after setting adis16448 registers