adding airframe config for s500 #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we keep this completely generic? Something like "Generic 500mm Quadcopter" instead of "S500". |
|
I'm on the fence on this one. It is for a very specific setup, and we might want to rename it. Goal is to provide a super consistent experience on this frame. |
|
Makes sense if there's going to be more specific parameters. |
|
@barzanisar Given that this got tuned, where are we standing with this? |
|
@LorenzMeier This hasn't been fine tuned yet. After solving its "preflight fail: mag inconsistent" check (I faced on the Flyday) I had switched my priority to crazyflie. I will tune, rename and commit the final parameters on Monday. |
|
This is safe to merge, renaming or additional tuning can continue off of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is a work in progress and will be edited later after fine tuning the gains.