Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins run tests under address sanitizer and fix issues #9421

Merged
merged 2 commits into from
May 18, 2018
Merged

Jenkins run tests under address sanitizer and fix issues #9421

merged 2 commits into from
May 18, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented May 5, 2018 •
edited by AuterionWrikeBot
Loading

No description provided.

@dagar
Copy link
Member Author

dagar commented May 6, 2018

2 failures

  1. mag declination (now part of ecl)
    image

  2. dataman
    image

@dagar dagar force-pushed the pr-tests_asan branch from 8014b0d to 764b4a4 Compare May 6, 2018 00:16
@dagar
Copy link
Member Author

dagar commented May 6, 2018

TODO - add proper shutdown so that we can run mission tests under asan. Currently it reports everything as a memory leak.

@dagar dagar force-pushed the pr-tests_asan branch from 54f862d to 1fe9a0c Compare May 6, 2018 00:38
@dagar dagar mentioned this pull request May 6, 2018
Merged
@dagar
Copy link
Member Author

dagar commented May 6, 2018

ECL geo_mag_lookup change - PX4/PX4-ECL#441

@dagar dagar changed the title [WIP] Jenkins run tests under address sanitizer Jenkins run tests under address sanitizer and fix issues May 6, 2018
@dagar dagar added this to the Release v1.8.0 milestone May 6, 2018
@dagar dagar requested a review from bkueng May 6, 2018 03:23
@bkueng
Copy link
Member

bkueng commented May 7, 2018

Regarding dataman: the only way how there can be an overflow is if item is out of bounds when accessing g_per_item_size and your change does not really fix that. The fix would be a simple bound check, and find out where the wrong index comes from.

@dagar dagar force-pushed the pr-tests_asan branch 2 times, most recently from 4801257 to 5619642 Compare May 17, 2018 22:51
@dagar
Copy link
Member Author

dagar commented May 17, 2018

@bkueng I was also trying to get rid of the variable sized array on the stack. Bounds check added.

@bkueng bkueng merged commit 2f553b9 into master May 18, 2018
@bkueng bkueng deleted the pr-tests_asan branch May 18, 2018 06:04
@mrpollo mrpollo mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡 bug
Projects
None yet
Milestone
Release v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @bkueng