Mission speed change not working

[julianoes]

In recent jMAVSim SITL tests using the Dronecode SDK I found that the MAVLink command MAV_CMD_DO_CHANGE_SPEED does not seem to have any effect.

No matter what the speed is set, the vehicle speed is always 5 m/s presumably the cruise velocity.

Firmware version: 0b548fa

[julianoes]

@bresch any idea why this happens?

[dagar]

Do you recall when it last worked?

[julianoes]

My guess it's limited to cruise velocity somewhere in position control or flight task but I couldn't find it yet.

[bresch]

Right, the velocity is limited by the cruise speed parameter. I have to check how "DO_CHANGE_SPEED" is implemented in the mavlink receiver.

[julianoes]

It's implemented in the navigator actually.

[julianoes]

Not fixed properly yet.

[julianoes]

@bresch did you find anything?

[bresch]

I need to discuss with @MaEtUgR for a proper fix, hopefully tomorrow we can have something.

[MaEtUgR]

Does this only happen with smooth mission enabled or always? Because #11772 only changed the smooth vel task which

1. is not the upstream default
2. gives us a hint where the problem is

[julianoes]

This happens with default jMAVSim SITL, so whatever comes with that. I don't know what sort of smoothing goes on.

[MaEtUgR]

There seem to be two problems:

• Mission speed does not get applied in the smooth mission (MPC_AUTO_MODE 1, default)
• Speeds above the cruise speed do not work in general also with MPC_AUTO_MODE 0.

[MaEtUgR]

I did a test with DronecodeSDK and make && build/default/integration_tests/integration_tests_runner --gtest_filter="SitlTest.MissionChangeSpeed" and at this point I still get the correct values: https://github.com/PX4/Firmware/blob/d9f8e37288d8e34baac79b32d71862045946534b/src/lib/FlightTasks/tasks/Auto/FlightTaskAuto.cpp#L129

[MaEtUgR]

@julianoes The DronecodeSDK test seems super picky:

[11:40:47|Info ] Mission status update: 2 / 4 (mission_change_speed.cpp:165)
[11:40:53|Warn ] speed check, should be: 3 m/s, actually: 3.06059 m/s (mission_change_speed.cpp:88)
[11:41:15|Debug] current: 3, total: 4 (mission_impl.cpp:1200)
[11:41:15|Info ] Mission status update: 3 / 4 (mission_change_speed.cpp:165)
[11:41:21|Warn ] speed check, should be: 8 m/s, actually: 8.07201 m/s (mission_change_speed.cpp:88)

but at least it succeeds if it's within +-1m/s.

[julianoes]

The warning is misleading, that should be a pass overall.