Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airspeed_selector follow up issue #12503

Closed
RomanBapst opened this issue Jul 17, 2019 · 6 comments
Closed

Airspeed_selector follow up issue #12503

RomanBapst opened this issue Jul 17, 2019 · 6 comments

Comments

@RomanBapst
Copy link
Contributor

@sfuhrer FYI
This issue is to keep track of some know limitations of the airspeed selector module #12353
Most of them are related to a setup with multiple airspeed sensors which is not yet supported in PX4.

  1. Make airspeed sensor detection and airspeed validator allocation dynamic
    There is a potential startup race condition when checking for orb_exists(ORB_ID(airspeed), i).

  2. Handling of airspeed scale factor across multiple airspeed validator instances. From which airspeed validator do we take the scale...

  3. When airspeed sensor has been declared invalid we need a better evaluation for when it's ok to use it again. One corner case could be e.g. when the wind estimator just did a reset but no heading change has taken place. In that case the innovations can be small even if the measured airspeed it totally off because the estimator initialized wind states to make everything consistent.

@stale
Copy link

stale bot commented Oct 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2019
@sfuhrer sfuhrer removed the stale label Oct 15, 2019
@sfuhrer
Copy link
Contributor

sfuhrer commented Oct 15, 2019

unrelated to #12887, so this is still valid

@stale
Copy link

stale bot commented Jan 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jan 13, 2020
@sfuhrer sfuhrer removed the stale label Jan 13, 2020
@stale
Copy link

stale bot commented Apr 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2020
@julianoes
Copy link
Contributor

@sfuhrer is this still up-to-date?

@stale stale bot removed the stale label Feb 9, 2021
@sfuhrer
Copy link
Contributor

sfuhrer commented Feb 9, 2021

@sfuhrer is this still up-to-date?

Kind of. But only relevant for non-default cases (multi airspeed, re-enabling a sensor after failure detected), so I would close this now as we anyway won't work on it soon.

@sfuhrer sfuhrer closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants