-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
micrortps_bridge: uorb multi-topics don't work #8530
Comments
I'm not that familiar with FastRTPS itself, but at a glance it doesn't look like the concept of multi-topics exists. I think we'll need to treat them like individual topics (sensor_accel_0, sensor_accel_1, etc), but it could be done automatically. The manually maintained message ids (https://github.com/PX4/Firmware/blob/master/msg/tools/uorb_rtps_message_ids.py#L5) are already a problem. So the entire thing needs to be considered. Should we discuss this on the messaging working group call? |
Sure. When's that? |
It's on Thursday, although I've never attended. The big overall issue that's not at all clear to me is how we need to handle message versioning and ids when you start using them outside of Firmware. |
@santiago3dr can we please keep this open? This is something that still needs to be tackled. |
closing old issues, if they are being worked on or need to remain open, let's give them higher priority |
Sure thing. I was actually unaware that this issue existed, but considering what I am working on now, makes sense to have it opened and solved asap. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing as stale. |
@TSC21 I believe you'll need to explicitly handle the instances as separate topics. |
Yes I know. Just didn't have time to implement this yet. |
Solution in #12137 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Solved already. |
Currently, uorb multi-topics (e.g.
optical_flow_raw
,vehicle_vision_position
, etc.) don't work with the micrortps_bridge.https://github.com/PX4/Firmware/blob/master/src/modules/micrortps_bridge/CMakeLists.txt
related to #8495. But I guess we need to fix it anyways.
@dagar I saw you've worked on it. Is that something you could look into?
The text was updated successfully, but these errors were encountered: