Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleBase allow multiple instances of a module #9143

Open
dagar opened this issue Mar 22, 2018 · 2 comments
Open

ModuleBase allow multiple instances of a module #9143

dagar opened this issue Mar 22, 2018 · 2 comments

Comments

@dagar
Copy link
Member

dagar commented Mar 22, 2018

There are many situations where we need to start more than one instance of an "app". Currently we do this for most drivers, but I also like to consider doing it for things like the wind_estimator or ekf2.

One idea would be giving ModuleBase some concept of instance. You'd use the same entrypoint, but an additional command line option would select the particular instance, likely default to the 1st instance when not specified. This instance number could then correspond to the particular parameters it uses, orb topics subscribed to and orb multi publish instance. Related parameter issue. #8821

Yet another option could be generating separate entry points for each. Something like...

ekf2 start
ekf2_2 start

We could then start using ModuleBase on all of the drivers.

Ideas for how we could approach this scalably?

@dagar
Copy link
Member Author

dagar commented Jun 24, 2019

#12191

@PX4 PX4 deleted a comment from stale bot Sep 25, 2019
@stale stale bot removed the Admin: Wont fix label Sep 25, 2019
@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants