Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM message simulator (dummy publisher) #14545

Merged
merged 25 commits into from
Apr 25, 2020
Merged

Conversation

roman-dvorak
Copy link
Contributor

Hi, this PR contains a simple application for publishing RPM message with custom value. It is useful for the development of the additional application that requires RPM message.

Usage:

rpm_simulator <rpm value>

nsh example:

pxh> listener rpm
never published

pxh> rpm_simulator 23.45
INFO  [rpm_simulator] RPM message with RPM=23.450 was published

pxh> listener rpm
TOPIC: rpm
 rpm_s
	indicated_frequency_rpm: 23.4500
	estimated_accurancy_rpm: 0.2345

pxh> rpm_simulator
INFO  [rpm_simulator] Usage: rpm_simulator <published RPM>
INFO  [rpm_simulator] Exit. Without publishing any message.

pxh> 

@roman-dvorak
Copy link
Contributor Author

Hi,
@dagar thank you for reviewing. This application was created according to PX4 dev guide where C non-objective access is used.
Thanks

@roman-dvorak roman-dvorak requested a review from dagar April 2, 2020 10:12
@roman-dvorak
Copy link
Contributor Author

I'm not sure why SITL tests fails. Please, can you give me some advice? Does it require some new tests for rpm_simulator?
I'm able to run SITL with gazebo.

@TSC21
Copy link
Member

TSC21 commented Apr 3, 2020

I'm not sure why SITL tests fails. Please, can you give me some advice? Does it require some new tests for rpm_simulator?
I'm able to run SITL with gazebo.

It's an unrelated fail. It's been intermitent since some days. We are looking into it.

@roman-dvorak
Copy link
Contributor Author

Please, @dagar, are there any other requirements? I think they're all fixed.

dagar
dagar previously approved these changes Apr 7, 2020
@roman-dvorak roman-dvorak requested a review from dagar April 8, 2020 11:30
@dagar
Copy link
Member

dagar commented Apr 8, 2020

It looks like a NuttX submodule change slipped in. Can you fix that and I'll merge?

@roman-dvorak
Copy link
Contributor Author

It is now merged with upstream/master

@roman-dvorak
Copy link
Contributor Author

I'm not sure why some tests were canceled.

@dagar
Copy link
Member

dagar commented Apr 8, 2020

The overall diff is still showing the NuttX submodule change, and now Tools/sitl_gazebo has changed as well.

@roman-dvorak
Copy link
Contributor Author

roman-dvorak commented Apr 13, 2020

@dagar now it looks, that it is possible to merge.

@roman-dvorak roman-dvorak requested a review from dagar April 25, 2020 10:40
@dagar dagar merged commit 75fe3be into PX4:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants