This repository has been archived by the owner on May 1, 2024. It is now read-only.
EKF: add flt_mag_align_complete to control_status flags #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CarlOlsson <[email protected]>
priseborough
previously approved these changes
Jan 6, 2019
|
Nitpick, but do we still need the |
|
True, I can remove it if no one speaks up against it |
Signed-off-by: CarlOlsson <[email protected]>
|
If this is merged, then a corresponding PR is required upstream to update the definition for https://github.com/PX4/Firmware/blob/master/msg/estimator_status.msg#L25 Can you please provide this and add a note that it is conditional on the changes in this ecl PR. |
LorenzMeier
approved these changes
Jan 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@priseborough I added the flt_mag_align_complete to the control_status flags since it controls quite some things internally in the EKF