Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: remove yaml for ros2 and ros1 messages #13

Closed
AuterionWrikeBot opened this issue Nov 15, 2018 · 8 comments · Fixed by #15
Closed

Feature: remove yaml for ros2 and ros1 messages #13

AuterionWrikeBot opened this issue Nov 15, 2018 · 8 comments · Fixed by #15
Assignees

Comments

@AuterionWrikeBot
Copy link

AuterionWrikeBot commented Nov 15, 2018

Goal: remove yaml that specifices map between ros2 and ros1 messages; this should not be required in the dynamic bridge

Status: Bug filed at https://github.com/ros2/rosidl_dds/blob/master/rosidl_generator_dds_idl/cmake/rosidl_generate_dds_interfaces.cmake ; dependency on opensplice still in system

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

I am going to prioritize this since it can be that the generated IDL's may be incompatible with the current IDL format expect by rmw_fastrpts

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

Looks like https://github.com/ros2/rosidl_dds/blob/master/rosidl_generator_dds_idl/cmake/rosidl_generate_dds_interfaces.cmake module is not working properly. Opened an issue so it can be tracked: ros2/rosidl_dds#48

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

Continuing the solving process: ros2/ros1_bridge#157

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

The problem here seems to be that the package naming does not end in "_msgs". The solution: build the messages as a separate package ("px4_msgs").

@TSC21
Copy link
Member

TSC21 commented Jan 20, 2019

Still to fix on the ros1 branch.

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

ros1_bridge is not building so to address this

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

Confirmed no yaml file is required now, since there's a bridge between 'px4_msgs'. So this is now at the point we wanted!

@AuterionWrikeBot
Copy link
Author

➤ Nuno Marques commented:

And completed here: e36bcda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants