Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused argument max_block_size in split_dense_variable() #9682

Closed
emailweixu opened this issue Apr 6, 2018 · 1 comment
Closed

Unused argument max_block_size in split_dense_variable() #9682

emailweixu opened this issue Apr 6, 2018 · 1 comment
Assignees

Comments

@emailweixu
Copy link
Collaborator

max_block_size is not used in this function:

def split_dense_variable(var_list,
pserver_count,
min_block_size=1024,
max_block_size=1048576):

@typhoonzero
Copy link
Contributor

This may be related to #9675. We can reduce the copy of split op and limit the max size of each parameter/gradient block, and send those blocks using an "IOthreadpool" ( which should contain much more threads than machine CPU cores).

And, in earlier tests result #7944, we see that split copying is not the major time-consuming operator, so we delayed this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants