Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Docs for Event Rules resource: Setting Advanced Condition to Optional #160

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Fixing Docs for Event Rules resource: Setting Advanced Condition to Optional #160

merged 2 commits into from
Oct 12, 2019

Conversation

stmcallister
Copy link
Contributor

Pointed out in Issue 155 that advanced_condition_json is actually optional. Fixing docs to say so.

heimweh
heimweh approved these changes Oct 12, 2019
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@heimweh heimweh merged commit 1118af8 into PagerDuty:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmcallister @heimweh