Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ruleset Data Source #237

Merged
merged 8 commits into from
Jun 1, 2020
Merged

Conversation

stmcallister
Copy link
Contributor

This adds the Ruleset Data Source along with Docs and tests (results shown below):

TF_ACC=1 go test -run "TestAccDataSourcePagerDutyRuleset_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccDataSourcePagerDutyRuleset_Basic
--- PASS: TestAccDataSourcePagerDutyRuleset_Basic (3.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	4.097s

@ghost ghost added the dependencies label May 29, 2020
@ghost ghost added size/XL and removed size/L labels May 29, 2020
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work @stmcallister 👌

route {
value = "P5DTL0K"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks a bit off, think a terraform fmt should fix it 🙂

@stmcallister stmcallister merged commit 8bdde9b into PagerDuty:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants