Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling service incident timeouts #44

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Allow disabling service incident timeouts #44

merged 2 commits into from
Oct 21, 2017

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 19, 2017

Resolves #41

@pdecat
Copy link
Contributor Author

pdecat commented Oct 19, 2017

Expected travis failure given the local vendor patch:

$ make vendor-status
The following packages are missing or modified locally:
	github.com/heimweh/go-pagerduty/pagerduty
Error: status failed for 1 package(s)
make: *** [vendor-status] Error 2
The command "make vendor-status" exited with 2.

@heimweh
Copy link
Collaborator

heimweh commented Oct 20, 2017

Hi @pdecat,

thanks for this PR.

This LGTM, as soon as the tests are green this should be good to go 👍

@pdecat
Copy link
Contributor Author

pdecat commented Oct 20, 2017

Hi @heimweh, vendor updated, all green :)

@heimweh heimweh added the bug label Oct 21, 2017
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pdecat,

thank you so much for this. This LGTM 👍

@heimweh heimweh merged commit 65301fb into PagerDuty:master Oct 21, 2017
@pdecat pdecat changed the title [WIP] Allow disabling service incident timeouts Allow disabling service incident timeouts Oct 21, 2017
@pdecat pdecat deleted the f-disable-service-timeouts branch November 8, 2017 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants