Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package @testing-library/jest-dom from 5.16.5 to 6.4.5 #2015

Closed
palisadoes opened this issue May 27, 2024 · 13 comments
Closed

Upgrade package @testing-library/jest-dom from 5.16.5 to 6.4.5 #2015

palisadoes opened this issue May 27, 2024 · 13 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix test Testing application

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade @testing-library/jest-dom from 5.16.5 to 6.4.5.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps @testing-library/jest-dom from 5.16.5 to 6.4.5.

Release notes

Sourced from @​testing-library/jest-dom's releases.

v6.4.5

6.4.5 (2024-05-03)

Bug Fixes

v6.4.4

6.4.4 (2024-05-03)

Bug Fixes

v6.4.3

6.4.3 (2024-05-03)

Bug Fixes

  • Updates role support for aria-required attribute in toBeRequired (#590) (20aca33)

v6.4.2

6.4.2 (2024-02-05)

Bug Fixes

  • Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations (#575) (a93c0c4)

v6.4.1

6.4.1 (2024-02-01)

Bug Fixes

  • Export type TestingLibraryMatchers from "./matchers" (#576) (dd1c4dd)

v6.4.0

6.4.0 (2024-01-30)

Features

v6.3.0

6.3.0 (2024-01-24)

... (truncated)

Commits
  • e8c8b13 fix: add js suffix to isEqualWith import (#599)
  • f03a582 fix(infra): codecoverage token addition (#600)
  • 20aca33 fix: Updates role support for aria-required attribute in toBeRequired (#590)
  • bd82f64 refactor: replace lodash with own implementation when possible (#593)
  • a93c0c4 fix: Remove errant export of GetByRoleMatcher, fixing type checking in some T...
  • c5c4e8d docs: add Dennis273 as a contributor for code (#581)
  • 978e3d4 docs: add kryops as a contributor for bug, code, and test (#580)
  • 73ad847 docs: add SteKoe as a contributor for bug, and code (#579)
  • d829ed9 docs: add jakeboone02 as a contributor for code, and test (#578)
  • 16499cf docs: add fpapado as a contributor for code, doc, and test (#573)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working security Security fix dependencies Pull requests that update a dependency file labels May 27, 2024
@github-actions github-actions bot added test Testing application unapproved labels May 27, 2024
Copy link

github-actions bot commented Jun 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@AbhinavKRN
Copy link

@palisadoes can you assign this issue to me?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 10, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. No active PRs. No activity.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 12, 2024
@ManjariRathore
Copy link
Contributor

Hello @Cioppolo14 @palisadoes
I would like to work on this issue, if possible can you assign this to me. I will raise a draft PR asap.

@akash0708
Copy link

Hello @palisadoes , I would like to work on this issue. I'm not working on any other issue hence will start with this immediately if assigned.

@akash0708
Copy link

In order to upgrade the jest-dom version I'm having to upgrade jest and @types/jest as well, since jest-dom 6.4.5 is not compatible with the current versions of the other two dependencies. Is that fine, should I go forward with it?

@akash0708
Copy link

I'm encountering this error when I run npm run test --watchAll=false --coverage

image

Can anyone help me out?

@palisadoes
Copy link
Contributor Author

Please ask the #talawa-admin slack channel.

@akash0708
Copy link

Thank you. I have asked in the specified slack channel

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 28, 2024
@palisadoes
Copy link
Contributor Author

Unassigning inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Sep 9, 2024
@ARYANSHAH1567
Copy link
Contributor

just wanted to know that if there is a merged pr with the updated package why is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix test Testing application
Projects
Archived in project
Development

No branches or pull requests

6 participants