Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx from Jest to Vitest #2480

Closed
varshith257 opened this issue Nov 26, 2024 · 13 comments
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@varshith257
Copy link
Member

varshith257 commented Nov 26, 2024

Is your feature request related to a problem? Please describe.

This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents and rename from test.tsx to spec.tsx
  2. Ensure all tests in src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional Context

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Nov 26, 2024
@varshith257 varshith257 changed the title Refactor: src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx from Jest to Vitest Refactor : src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx from Jest to Vitest Nov 26, 2024
@dhirajudhani
Copy link
Contributor

@varshith257 can you assign this to me

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@im-vedant
Copy link
Contributor

@palisadoes Can you assign this issue to me?

@palisadoes
Copy link
Contributor

Unassigning. Inactivity

@im-vedant im-vedant removed their assignment Jan 2, 2025
@Nexusrex18
Copy link

Hi, I noticed that this issue is currently unassigned, and no one seems to be working on it. I’d like to take it up and contribute. Could you please assign it to me?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 12, 2025
@Cioppolo14
Copy link
Contributor

  • Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@gurramkarthiknetha
Copy link
Contributor

i would like to work on this .could you assign this issue to me @Cioppolo14

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 12, 2025
@Nexusrex18
Copy link

Nexusrex18 commented Jan 12, 2025

@Cioppolo14
Sure, you can assign anyone else actually I have tried but even after many tries didn't get any positive result.

@shivasankaran18
Copy link
Contributor

can I work on this issue ..? @palisadoes @Cioppolo14

@NishantSinghhhhh
Copy link
Contributor

@Cioppolo14 , @palisadoes , can i work on this isssue ???

@NishantSinghhhhh
Copy link
Contributor

@Cioppolo14 and @palisadoes , this issue also can be closed as the component AddOnStore is already having a vitest file present

Screenshot from 2025-01-13 00-10-27

@palisadoes
Copy link
Contributor

@varshith257

  1. The code coverage isn't changing after dozens of PRs converting from Jest to Vitest. How can this be rectified?
  2. It's clear the GitHub actions need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Status: Done
Status: Done
Development

No branches or pull requests

9 participants