Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/screens/Users from Jest to Vitest #2585

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 8 comments
Closed

Refactor: src/screens/Users from Jest to Vitest #2585

VanshikaSabharwal opened this issue Dec 1, 2024 · 8 comments
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/Users pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 1, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation feature request labels Dec 3, 2024
@antriksh-9
Copy link
Contributor

Hey @VanshikaSabharwal, I want to work on this issue.
Pleas assign it to me.

@VanshikaSabharwal
Copy link
Contributor Author

Hello @antriksh-9 I am not maintainer. So, i cannot assign you. Kindly ask @palisadoes @varshith257 @pranshugupta54 to assign you the issue

@Shivanshu34
Copy link

Hey @VanshikaSabharwal I want to work in this

@VanshikaSabharwal
Copy link
Contributor Author

@Shivanshu34 You can ask @palisadoes @varshith257 to assign it to you

@Cioppolo14
Copy link
Contributor

If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@palisadoes
Copy link
Contributor

@antriksh-9 Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@Ramneet04
Copy link
Contributor

This issue is resolved I guess I run the test and it is working fine, does it require any changes????

@palisadoes
Copy link
Contributor

yes, it's fixed

@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Dec 26, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Archived in project
Development

No branches or pull requests

7 participants