Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: src/setup/askForCustomPort/askForCustomPort.test.ts from Jest to Vitest #2748

Closed
palisadoes opened this issue Dec 24, 2024 · 9 comments
Assignees
Labels
refactor Refactor the code to improve its quality test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 24, 2024

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Rename the test file from having a .test.* suffix to a .spec.* suffix
  3. Ensure all tests in the file pass after migration using npm run test:vitest
  4. Maintain the test coverage for the file as 100% after migration
  5. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 24, 2024
@palisadoes palisadoes changed the title Refactor: /setup/askForCustomPort/askForCustomPort.test.ts from Jest to Vitest Refactor: src/setup/askForCustomPort/askForCustomPort.test.ts from Jest to Vitest Dec 24, 2024
@palisadoes palisadoes removed documentation Improvements or additions to documentation feature request labels Dec 24, 2024
@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@hustlernik
Copy link
Contributor

@palisadoes Want to take this up.

@palisadoes
Copy link
Contributor Author

@palisadoes Want to take this up.

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@palisadoes
Copy link
Contributor Author

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@hustlernik
Copy link
Contributor

@palisadoes Currently, only one issue is assigned to me.

@palisadoes
Copy link
Contributor Author

@palisadoes Currently, only one issue is assigned to me.

  1. You are already working on two issues.
    image
  2. You also have no submitted PRs
    image

Please give others a chance

@hustlernik
Copy link
Contributor

hustlernik commented Dec 24, 2024

@palisadoes Issue is not closed but PR is merged. So I have just one active issue to work on. No Problem everyone should get a chance, I agree.

image

@palisadoes
Copy link
Contributor Author

My error. I've assigned it.

@hustlernik
Copy link
Contributor

It happens, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor the code to improve its quality test Testing application
Projects
Status: Done
Archived in project
Development

No branches or pull requests

3 participants