Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Improve Comment Validation Error Message for Users #3142

Closed
Nivedita-Chhokar opened this issue Jan 4, 2025 · 3 comments
Closed
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@Nivedita-Chhokar
Copy link

Describe the bug
When a user submits an empty comment, the application currently shows a technical error message: "Comment validation failed: text: Path 'text' is required." This message is intended for developers and is not suitable for users. It should be replaced with a more user-friendly message like "Please enter a comment before submitting." The original technical message should be kept in the logs for developer reference, but not displayed to end-users.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the comment section.
  2. Leave the comment field empty.
  3. Submit the comment.
  4. Observe the technical error message displayed.

Expected behavior
A user-friendly error message like "Please enter a comment before submitting."

Actual behavior
A technical error message: "Comment validation failed: text: Path 'text' is required."

Screenshots
Before Fix:
Screenshot 2025-01-05 015249
After Fix:
Screenshot 2025-01-05 021900

Additional details
I've implemented a fix locally by updating the error handling logic to show a more appropriate message to the users while keeping the developer-specific message for internal logs.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Nivedita-Chhokar Nivedita-Chhokar added the bug Something isn't working label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Nivedita-Chhokar
Copy link
Author

Nivedita-Chhokar commented Jan 4, 2025

I have resolved the issue and would like to be assigned to it for further review and integration.
@palisadoes

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
None yet
Development

No branches or pull requests

2 participants