Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Update the envFiles/ configurations to be compatible with Talawa Admin #2860

Closed
palisadoes opened this issue Jan 16, 2025 · 7 comments
Assignees

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. This comment lists the URLs for accessing the API:
    1. NoMongo:Fixing the 404 error even after having a running talawa-api talawa-admin#3266 (comment)
  2. This is not documented in the INSTALLATION.md file
  3. Talawa-Admin expects the API to be listening on port 4000. The current configuration is 8080
  4. The content below is for envFiles/.env.devcontainer
    API_BASE_URL=http://127.0.0.1:8080
    API_HOST=0.0.0.0
    API_IS_GRAPHIQL=true
    API_PORT=8080
    CI=false
    NODE_ENV=production
    API_MAPPED_HOST_IP=127.0.0.1
    API_MAPPED_PORT=8080
    CADDY_HTTP_MAPPED_PORT=80
    CADDY_HTTPS_MAPPED_PORT=443
    CADDY_HTTP3_MAPPED_PORT=443
    CADDY_TALAWA_API_DOMAIN_NAME=localhost
    CADDY_TALAWA_API_HOST=api
    CADDY_TALAWA_API_PORT=8080
    CLOUDBEAVER_ADMIN_NAME=talawa
    CLOUDBEAVER_ADMIN_PASSWORD=password
    CLOUDBEAVER_MAPPED_HOST_IP=127.0.0.1
    CLOUDBEAVER_MAPPED_PORT=8978
    CLOUDBEAVER_SERVER_NAME=Talawa CloudBeaver Server
    CLOUDBEAVER_SERVER_URL=http://127.0.0.1:8978
    
  5. The content below is for envFiles/.env.devcontainer
    API_BASE_URL=http://127.0.0.1:8080
    API_HOST=0.0.0.0
    API_IS_GRAPHIQL=false
    API_PORT=8080
    CI=true
    NODE_ENV=production
    CADDY_HTTP_MAPPED_PORT=80
    CADDY_HTTPS_MAPPED_PORT=443
    CADDY_HTTP3_MAPPED_PORT=443
    CADDY_TALAWA_API_DOMAIN_NAME=localhost
    CADDY_TALAWA_API_HOST=api
    CADDY_TALAWA_API_PORT=8080
    
  6. The content below is for envFiles/.env.devcontainer
    API_BASE_URL=
    API_HOST=0.0.0.0
    API_IS_GRAPHIQL=false
    API_PORT=8080
    CI=false
    NODE_ENV=production
    CADDY_HTTP_MAPPED_PORT=80
    CADDY_HTTPS_MAPPED_PORT=443
    CADDY_HTTP3_MAPPED_PORT=443
    CADDY_TALAWA_API_DOMAIN_NAME=
    CADDY_TALAWA_API_HOST=api
    CADDY_TALAWA_API_PORT=8080
    

Describe the solution you'd like

  1. Update the envFiles/* files, replacing port 8080 with port 4000 to make the app compatible with Talawa-Admin's defaults

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

-N/A

Additional context

Related issues:

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes
Copy link
Contributor Author

@xoldd FYI

@xoldd
Copy link
Contributor

xoldd commented Jan 16, 2025

This is not documented in the INSTALLATION.md file

The environment variables are documented here in this file because talawa api docusaurus docs weren't meant to be touched right now as you had suggested: https://github.com/PalisadoesFoundation/talawa-api/blob/develop-postgres/documentation/environment_variables.md

But yeah, the default port used by talawa api should be documented in INSTALLATION.md file.

Talawa-Admin expects the API to be listening on port 4000. The current configuration is 8080

Port 8080 is used because it is one of the standard secondary ports used for http(standard primary port being port 80): https://www.speedguide.net/port.php?port=8080

Update the envFiles/* files, replacing port 8080 with port 4000 to make the app compatible with Talawa-Admin's defaults

Just updating the default value for port from 4000 to 8080 on talawa admin would fix it as well. Api is designed with sane, standard defaults so not sure why changes to it are needed to fix non standard client behavior.

@palisadoes
Copy link
Contributor Author

We changed the port to 4000 because we used to have developers running multiple apps on default ports and asking us why things fail

@xoldd
Copy link
Contributor

xoldd commented Jan 16, 2025

@palisadoes If developers have default ports used by talawa applications acquired by other unrelated applications they need to use custom values for the talawa application ports in the .env files. This isn't exclusive to port 8080 and using port 4000 isn't any different.

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 16, 2025

  1. It also means we have an application specific port for all future versions.
  2. Less things to explain to the Admin developers too. It gets very busy.

@IITI-tushar
Copy link

@palisadoes i would like to work on it... please assign me this and unassign me from this switchmap-ng-208

@hustlernik
Copy link

@palisadoes can i take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants