Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for chat_input_field.dart #1406

Closed
palisadoes opened this issue Jan 24, 2023 · 21 comments · Fixed by #1650
Closed

Views: Create tests for chat_input_field.dart #1406

palisadoes opened this issue Jan 24, 2023 · 21 comments · Fixed by #1650
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/chat/widgets/chat_input_field.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/after_auth_screens/chat/widgets/chat_input_field_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Jan 24, 2023
@Sudhanva-Nadiger
Copy link

Can I work on this ?

@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed unapproved Unapproved, needs to be triaged bug Something isn't working parent The issue is generating more sub-issues labels Jan 24, 2023
@literalEval
Copy link
Member

I would like to work on this issue if @Sudhanva-Nadiger is not actively working.

@camelCase02
Copy link

Hello Palisadoes, I am new here and would like to contribute in this issue

@palisadoes
Copy link
Contributor Author

@Sudhanva-Nadiger Are you still working on this? It's been 2 weeks.

@Sudhanva-Nadiger Sudhanva-Nadiger removed their assignment Feb 7, 2023
@camelCase02
Copy link

@palisadoes , can you please assign this issue to me ?

@Skdahale
Copy link

Skdahale commented Feb 9, 2023

@palisadoes Can I work on this issue

@noman2002
Copy link
Member

@usmanIITR Any update ?

@noman2002
Copy link
Member

@Skdahale Assigned you one issue. Please work on it and get the PR merged.

@noman2002 noman2002 added the unapproved Unapproved, needs to be triaged label Feb 19, 2023
@noman2002
Copy link
Member

Unassigned due to inactivity.

@camelCase02
Copy link

sorry @noman2002 I am a beginner in flutter, I was trying to solve this issue but was not able to do it

@camelCase02
Copy link

Also I didn't get the notification that you mentioned me, so missed your message

@camelCase02
Copy link

I'll try to complete easy issues

@Ayush0Chaudhary
Copy link
Contributor

@noman2002 @palisadoes @xoldyckk @TheHazeEffect can you please assign me this.

@palisadoes
Copy link
Contributor Author

@Ayush0Chaudhary You already have 2 issues assigned.

@ikjot-2605
Copy link
Contributor

@palisadoes @noman2002 I have created 2 PRs for my currently assigned issues. Could you assign me this as well, so that I can keep working on the project?

@palisadoes
Copy link
Contributor Author

@ikjot-2605 You already have two issues. I made an exception before, however we also need to consider others getting a chance to contribute. Please wait until at least one of your other PRs are merged.

@ikjot-2605
Copy link
Contributor

@ikjot-2605 You already have two issues. I made an exception before, however we also need to consider others getting a chance to contribute. Please wait until at least one of your other PRs are merged.

Understood, apologies for the inconvenience.

@Kushalrock
Copy link
Contributor

@palisadoes May I take up this issue? As I have already completed my app localization test ting with complete code coverage.

@jadeharr
Copy link

jadeharr commented Mar 7, 2023

@Kushalrock You have two issues open. Please wait until at least one of your other PRs have been merged.

@Kushalrock
Copy link
Contributor

@jadeharr Ya I am waiting for review it's been some time. I thought in the meanwhile I could take up one more issue. This issue interested me so i commented on it.

@Kushalrock
Copy link
Contributor

@palisadoes Now can I take up this issue? Thank you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants