Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of all toasts to a common widget #716

Closed
utkarshshendge opened this issue Apr 25, 2021 · 2 comments · Fixed by #742
Closed

Migration of all toasts to a common widget #716

utkarshshendge opened this issue Apr 25, 2021 · 2 comments · Fixed by #742
Assignees
Labels
good first issue Good for newcomers

Comments

@utkarshshendge
Copy link
Contributor

utkarshshendge commented Apr 25, 2021

  • Parent issue : Refactoring of codebase and separation on data/UI #715
  • Issue Description:
    Migration of all the success and error toast to a common widget in success_toast.dart
    The widget here needs some modifications to make it universal. Like it needs two required parameters message andisSuccesswith an option parameter duration. After which this widget needs to be used at all the places in the project by just passing the message, isSuccess, and duration if needed. After successfully accomplishing the task the file toast_tile.dart can be deleted with the file success_toast.dart renamed to something more appropriate liketoast.dartetc.
  • Issue Severity:
    Low
  • Environment Details:
    Project Level
  • Observed Behaviour:
    Toasts are coded multiple times, can be moved to single file
  • Expected Behaviour:
    Removal of unused widgets, unused files. Generation of reusable widgets
  • Does this issue need immediate attention?
    No
  • Please ask mentors/maintainers to assign if you are willing to work on this issue.
@utkarshshendge
Copy link
Contributor Author

I would like to work on this.

@palisadoes
Copy link
Contributor

Issue #700 has now been integrated into the pull request process. It will flag all Dart files that are longer than 300 lines to help with readability. Please make sure your contribution reduces file sizes to within this limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment