Added Asynchronous Lifecycle hooks #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +28,8 @@ let beforeEach = global.beforeEach; | |||
| let afterAll = global.after; | |||
| let afterEach = global.afterEach; | |||
|
|
|||
| let nodeSymbol = global.Symbol || (key => "__mts_" + key); | |||
| //let nodeSymbol = global.Symbol || (key => "__mts_" + key); | |||
| let nodeSymbol = (key => "__mts_" + key); | |||
There was a problem hiding this comment.
I really liked the way it worked with symbols, but since symbol seem to cause problems on some node versions, perhaps it really is best to drop the idea.
|
This looks great, I will publish a new version at NPM right away. |
|
Danke schön! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should solve #5 and also adds the ability to return promises in hooks on which mocha will wait for either their resolve or reject and will fail if it is rejected. Also (of course) adapted test.ts to reflect the changes made to the source.
And added typings because... it kinda made sense and I couldn't find find a @types-npm-package for symbol-shim (would have been dev-dependency).
Sorry for my (perhaps?) bad english. Greetings from germany.