Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing the raySize of LivingEntity#rayTraceEntities #9942

Closed
TheLimeGlass opened this issue Nov 13, 2023 · 1 comment · May be fixed by #11907
Closed

Allow changing the raySize of LivingEntity#rayTraceEntities #9942

TheLimeGlass opened this issue Nov 13, 2023 · 1 comment · May be fixed by #11907
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.

Comments

@TheLimeGlass
Copy link

TheLimeGlass commented Nov 13, 2023 •
edited
Loading

Is your feature request related to a problem?

Allow changing the raySize of LivingEntity#rayTraceEntities
This will never include Displays because Displays have a hitbox of 0.

Describe the solution you'd like.

Allowing the definition of the raySize so developers can include Displays.

Describe alternatives you've considered.

Requiring Spigot's long method

result = origin.getWorld().rayTraceEntities(origin.getEyeLocation(), location.getDirection(), 100, 1.0D, entity -> !entity.equals(origin));

Other

I told Spigot about this, and they're adding a JavaDoc to World#rayTraceEntities to tell developers to define the raySize for Displays. Rather than the method that inputs 0.0D for the raySize.
@TheLimeGlass TheLimeGlass added status: needs triage type: feature Request for a new Feature. labels Nov 13, 2023
@emilyy-dev
Copy link
Member

I think that we could introduce some sort of RayTraceBuilder, akin to the ParticleBuilder, to better streamline the process of ray tracing, rather than adding Yet Another Overload™️

@Warriorrrr Warriorrrr added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Feb 10, 2024
@notTamion notTamion mentioned this issue Feb 10, 2024
Closed
@PaperMC PaperMC locked and limited conversation to collaborators Apr 28, 2024
@codebycam codebycam converted this issue into discussion #10596 Apr 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RayTraceConfigurationBuilder notTamion/paper
Add RayTraceConfiguration notTamion/paper
3 participants
@TheLimeGlass @emilyy-dev @Warriorrrr