Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down after hard crash fails at savePlayers #12030

Closed
spring-dependency-management opened this issue Jan 27, 2025 · 1 comment
Closed

Shut down after hard crash fails at savePlayers #12030

spring-dependency-management opened this issue Jan 27, 2025 · 1 comment
Labels
version: 1.21.4 Game version 1.21.4

Comments

@spring-dependency-management
Copy link
Contributor

spring-dependency-management commented Jan 27, 2025

Expected behavior

the error shouldn't halt execution for the whole server jar, worlds should attempt to save

Observed/Actual behavior

The whole server halts execution indefinitely as the shutdown process fails, an interrupted shut down process means server is down forever until process is manually killed.

[17:29:57] [Paper Watchdog Thread/INFO]: [ProtocolLib] Disabling ProtocolLib v5.4.0-SNAPSHOT-739
[17:29:57] [Paper Watchdog Thread/INFO]: Saving players
[17:29:57] [Paper Watchdog Thread/WARN]: Asynchronous Save Players! Blocking thread until it returns 
java.lang.IllegalStateException: null
	at io.papermc.paper.util.MCUtil.ensureMain(MCUtil.java:116) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at net.minecraft.server.players.PlayerList.saveAll(PlayerList.java:1073) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at net.minecraft.server.players.PlayerList.saveAll(PlayerList.java:1069) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1016) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:755) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at net.minecraft.server.MinecraftServer.close(MinecraftServer.java:974) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
	at org.spigotmc.WatchdogThread.run(WatchdogThread.java:146) ~[paper-1.21.4.jar:1.21.4-DEV-5a34bf0]
... Server dead forever

Image

Steps/models to reproduce

Hard crash a server using thread.sleep(999999), it should at-least attempt to save the world to prevent corruption, some recent patch has broken this behaviour though.

Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.4-DEV-main@5a34bf0 (1970-01-01T00:00:00Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.4-DEV-88bbead (MC: 1.21.4)

Other

No response

@Spottedleaf
Copy link
Member

Resolved in a392d47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: 1.21.4 Game version 1.21.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants