Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usage stats #10260

Merged
merged 15 commits into from
Oct 21, 2024
Merged

Conversation

nickoferrall
Copy link
Contributor

Fix #10259

AC

  • Usage stats has been safely removed

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

<NotificationTemplate
avatar={orgPicture || defaultOrgAvatar}
message={`"${orgName}" is over the limit of ${Threshold.MAX_STARTER_TIER_TEAMS} free teams. Action is needed.`}
action={<NotificationAction label={'See Usage'} onClick={onActionClick} />}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teams limit directs users to the Usage page, so I think it's safe to remove

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall
Copy link
Contributor Author

nickoferrall commented Oct 8, 2024

Hey @mattkrick, just bumping the review request on this one 🙏

It looks like this PR includes some of the changes from the remove team insights PR #10270 too. Sorry about that - I'm not sure why it's showing up when the team insights PR has been merged.

@nickoferrall nickoferrall removed the request for review from mattkrick October 8, 2024 11:26
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall nickoferrall changed the base branch from master to production October 8, 2024 11:31
@nickoferrall nickoferrall changed the base branch from production to master October 8, 2024 11:31
@nickoferrall nickoferrall requested a review from mattkrick October 8, 2024 11:33
@nickoferrall
Copy link
Contributor Author

Hey @mattkrick , bumping this one as it's getting stale

Copy link
Member

@mattkrick mattkrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall nickoferrall merged commit e6238a5 into master Oct 21, 2024
7 checks passed
@nickoferrall nickoferrall deleted the feat/10259/remove-domain-insights branch October 21, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove domain insights
2 participants