-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modified/added meta tags with new content #10652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the goal of some of the changes is. If we want to have a nice preview in Slack etc. for different routes, I think there is no way around serving different versions of index.html based on route, so we could have 1 generic, 1 for mass invite and 1 for team invite?
Let me know if I'm just missing something here.
packages/client/modules/teamDashboard/components/TeamDashMain/TeamDashMain.tsx
Outdated
Show resolved
Hide resolved
I was following work from here: https://www.notion.so/parabol/c8419b4417324a8cae36570631e62beb?v=c18a873d44014bc3ab24eb850e325771&pvs=4 Your comments make sense to me. I am going to adjust the goal of this work to simply update the meta text to broaden our intent slightly beyond agile for unauthenticated routes and back the rest of the changes out. |
bf252ff
to
e7475d4
Compare
@Dschoordsch thank you for the review! I updated based upon your comments |
@jordanh Please next time press the "Re-request review" button as I might miss mentions. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
Closes #9407
Testing scenarios
Navigate to Sign-Up Page
Navigate to Create Account Page
Share an invitation link
Share any other URL
Final checklist