Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support image resizing in TipTap #10747

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: Support image resizing in TipTap #10747

merged 3 commits into from
Jan 29, 2025

Conversation

mattkrick
Copy link
Member

Description

Images are too big for reflections. This sets the default max height to the height of the editor. It then persists width & height to the node so images will take up the right amount of space before the image loads so there's no content shifting

@mattkrick mattkrick merged commit 4fb5f96 into master Jan 29, 2025
7 checks passed
@mattkrick mattkrick deleted the feat/image-resize branch January 29, 2025 22:58
Copy link

sentry-io bot commented Jan 31, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'getValue') removeReflectionMeetingUpdater(packages/client/... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant