chore: Refactor tiptap events #10800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
24 tasks
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Dschoordsch
reviewed
Feb 6, 2025
| setLinkState={setLinkState} | ||
| useLinkEditor={() => useTaskChild('editor-link-changer')} | ||
| /> | ||
| <TipTapEditor editor={editor} useLinkEditor={() => useTaskChild('editor-link-changer')} /> |
There was a problem hiding this comment.
@mattkrick We get linter warnings for this one because we pass hooks in a callback. I think it should work if we're careful, but it seems to be not a good idea and not a pattern I would like to keep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I really didn't like the leaky abstraction I originally built where linkState was created by the parent Component & passed to useEditor and then TipTapEditor.
This fixes it by using the event emitter built into the editor. Keeps everything modular and cleeeean.
Also adds underlines to the bubble menu