Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orgAdmin): add sortable memberCount and lastMetAt columns in OrgTeams view #10846

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Feb 11, 2025

Description

Closes #10845

Demo

2025-02-11 15 11 06

Testing scenarios

  • Default sorting

    • Go to http://localhost:3000/me/organizations/E3wNXGxEZy/teams
    • See teams are sorted by Last Met At date by default, descending
  • Sortable columns

    • Go to http://localhost:3000/me/organizations/E3wNXGxEZy/teams
    • Click Member Count or Last Met At to sort the teams by the column

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe linked an issue Feb 11, 2025 that may be closed by this pull request
3 tasks
@tianrunhe tianrunhe merged commit c04bb94 into master Feb 12, 2025
9 checks passed
@tianrunhe tianrunhe deleted the feat/10845/orgTeamsView branch February 12, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrgTeamsView: sort by lastMetAt date, show member count
2 participants