Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getCreatedBySomeoneElseComment with addCreatedBySomeoneElseComment #6238

Closed
2 tasks
igorlesnenko opened this issue Mar 18, 2022 · 0 comments
Closed
2 tasks
Assignees

Comments

@igorlesnenko
Copy link
Contributor

igorlesnenko commented Mar 18, 2022

Having getCreatedBySomeoneElseComment makes code and types more complicated

See JiraServer example here: #6059

// TODO: implement addCreatedBySomeoneElseComment instead
getCreatedBySomeoneElseComment(
viewerName: string,
assigneeName: string,
teamName: string,
teamDashboardUrl: string
): Doc | string
}

AC:
Replace getCreatedBySomeoneElseComment with addCreatedBySomeoneElseComment for

  • Jira
  • GitHub
@igorlesnenko igorlesnenko self-assigned this Mar 18, 2022
@igorlesnenko igorlesnenko moved this to To Prioritize in Sprint Board Beta Mar 18, 2022
@igorlesnenko igorlesnenko moved this from To Prioritize to In Progress in Sprint Board Beta Mar 18, 2022
@igorlesnenko igorlesnenko moved this from In Progress to Maintainer Review in Sprint Board Beta Mar 23, 2022
@igorlesnenko igorlesnenko moved this from Maintainer Review to In Progress in Sprint Board Beta Mar 23, 2022
Repository owner moved this from In Progress to Done in Sprint Board Beta Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants