Better logging with winston #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
| @@ -254,7 +263,7 @@ class ParseServer { | |||
| if (!process.env.TESTING) { | |||
| process.on('uncaughtException', (err) => { | |||
| if ( err.code === "EADDRINUSE" ) { // user-friendly message for this common error | |||
| console.log(`Unable to listen on port ${err.port}. The port is already in use.`); | |||
| log.error(`Unable to listen on port ${err.port}. The port is already in use.`); | |||
There was a problem hiding this comment.
This one I think actually should be console.log
|
Looks good to me aside from the one thing. @peterdotjs you wrote most of this code, want to take a look? |
|
LGTM. |
|
Merge when you like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes all logs (including verbose) through winston.
Makes all logs available through the API