Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-structure Factory deployment & events #71

Open
anna-carroll opened this issue Jan 14, 2022 · 1 comment
Open

re-structure Factory deployment & events #71

anna-carroll opened this issue Jan 14, 2022 · 1 comment
Assignees

Comments

@anna-carroll
Copy link
Contributor

  • deploy PartyBid, PartyBuy, and collectionParty implementations separately from factory
  • have functions for multisig to update implementations deployed
  • log deployedAt[proxy] = block.timestamp for all deployed proxies
  • emit Party___Deployed event with all the params in Implementation initialize so it's always available from the Party contract
  • emit ProxyDeployed event with only the address when any proxy is deployed (for discoverability)

On frontend, get event from Party contract itself always & always verify that contract was deployed by factory

@anna-carroll anna-carroll self-assigned this Jan 14, 2022
@anna-carroll
Copy link
Contributor Author

@steveklebanoff what do you think about re-structuring events like this so they are easier to query from the frontend? even if we change factory addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant