feature_llmq_chainlocks.py

#!/usr/bin/env python3
# Copyright (c) 2015-2024 The Dash Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.

'''
feature_llmq_chainlocks.py

Checks LLMQs based ChainLocks

'''

import time
from io import BytesIO

from test_framework.messages import CBlock, CCbTx
from test_framework.test_framework import DashTestFramework
from test_framework.util import assert_equal, assert_raises_rpc_error, force_finish_mnsync


class LLMQChainLocksTest(DashTestFramework):
    def set_test_params(self):
        self.set_dash_test_params(5, 4)

    def run_test(self):
        # Connect all nodes to node1 so that we always have the whole network connected
        # Otherwise only masternode connections will be established between nodes, which won't propagate TXs/blocks
        # Usually node0 is the one that does this, but in this test we isolate it multiple times
        for i in range(2, len(self.nodes)):
            self.connect_nodes(i, 1)

        self.test_coinbase_best_cl(self.nodes[0], expected_cl_in_cb=False)

        self.activate_mn_rr(expected_activation_height=900)
        self.log.info("Activated MN_RR at height:" + str(self.nodes[0].getblockcount()))

        # v20 is active for the next block, not for the tip
        self.test_coinbase_best_cl(self.nodes[0], expected_cl_in_cb=False)

        # v20 is active, no quorums, no CLs - null CL in CbTx
        nocl_block_hash = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[0]
        self.test_coinbase_best_cl(self.nodes[0], expected_cl_in_cb=True, expected_null_cl=True)
        cbtx = self.nodes[0].getspecialtxes(nocl_block_hash, 5, 1, 0, 2)[0]
        assert_equal(cbtx["instantlock"], False)
        assert_equal(cbtx["instantlock_internal"], False)
        assert_equal(cbtx["chainlock"], False)


        self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0)
        self.wait_for_sporks_same()

        self.mine_cycle_quorum()
        self.wait_for_chainlocked_block_all_nodes(self.nodes[0].getbestblockhash())

        self.log.info("Mine single block, ensure it includes latest chainlock")
        self.generate(self.nodes[0], 1, sync_fun=self.sync_blocks)
        self.test_coinbase_best_cl(self.nodes[0])

        # ChainLock locks all the blocks below it so nocl_block_hash should be locked too
        cbtx = self.nodes[0].getspecialtxes(nocl_block_hash, 5, 1, 0, 2)[0]
        assert_equal(cbtx["instantlock"], True)
        assert_equal(cbtx["instantlock_internal"], False)
        assert_equal(cbtx["chainlock"], True)

        self.log.info("Mine many blocks, wait for chainlock")
        self.generate(self.nodes[0], 20, sync_fun=self.no_op)
        # We need more time here due to 20 blocks being generated at once
        self.wait_for_chainlocked_block_all_nodes(self.nodes[0].getbestblockhash(), timeout=30)
        self.test_coinbase_best_cl(self.nodes[0])

        self.log.info("Assert that all blocks up until the tip are chainlocked")
        for h in range(1, self.nodes[0].getblockcount()):
            block = self.nodes[0].getblock(self.nodes[0].getblockhash(h))
            assert block['chainlock']

        self.log.info(f"Test submitchainlock for too high block")
        assert_raises_rpc_error(-1, f"No quorum found. Current tip height: {self.nodes[1].getblockcount()}", self.nodes[1].submitchainlock, '0000000000000000000000000000000000000000000000000000000000000000', 'a5c69505b5744524c9ed6551d8a57dc520728ea013496f46baa8a73df96bfd3c86e474396d747a4af11aaef10b17dbe80498b6a2fe81938fe917a3fedf651361bfe5367c800d23d3125820e6ee5b42189f0043be94ce27e73ea13620c9ef6064', self.nodes[1].getblockcount() + 300)

        self.log.info("Update spork to SPORK_19_CHAINLOCKS_ENABLED and test its behaviour")
        self.nodes[0].sporkupdate("SPORK_19_CHAINLOCKS_ENABLED", 1)
        self.wait_for_sporks_same()

        self.log.info("Generate new blocks and verify that they are not chainlocked")
        previous_block_hash = self.nodes[0].getbestblockhash()
        for _ in range(2):
            block_hash = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[0]
            self.wait_for_chainlocked_block_all_nodes(block_hash, expected=False)
            assert self.nodes[0].getblock(previous_block_hash)["chainlock"]

        self.nodes[0].sporkupdate("SPORK_19_CHAINLOCKS_ENABLED", 0)
        self.wait_for_sporks_same()

        self.log.info("Isolate node, mine on another, and reconnect")
        self.isolate_node(0)
        node0_mining_addr = self.nodes[0].getnewaddress()
        node0_tip = self.nodes[0].getbestblockhash()
        self.generatetoaddress(self.nodes[1], 5, node0_mining_addr, sync_fun=self.no_op)
        self.wait_for_chainlocked_block(self.nodes[1], self.nodes[1].getbestblockhash())
        self.test_coinbase_best_cl(self.nodes[0])
        assert self.nodes[0].getbestblockhash() == node0_tip
        self.reconnect_isolated_node(0, 1)
        self.generatetoaddress(self.nodes[1], 1, node0_mining_addr, sync_fun=self.no_op)
        self.wait_for_chainlocked_block_all_nodes(self.nodes[1].getbestblockhash())
        self.test_coinbase_best_cl(self.nodes[0])

        self.log.info("Isolate node, mine on another, reconnect and submit CL via RPC")
        self.isolate_node(0)
        self.generate(self.nodes[1], 1, sync_fun=self.no_op)
        self.wait_for_chainlocked_block(self.nodes[1], self.nodes[1].getbestblockhash())
        best_0 = self.nodes[0].getbestchainlock()
        best_1 = self.nodes[1].getbestchainlock()
        assert best_0['blockhash'] != best_1['blockhash']
        assert best_0['height'] != best_1['height']
        assert best_0['signature'] != best_1['signature']
        assert_equal(best_0['known_block'], True)
        node_height = self.nodes[1].submitchainlock(best_0['blockhash'], best_0['signature'], best_0['height'])
        rpc_height = self.nodes[0].submitchainlock(best_1['blockhash'], best_1['signature'], best_1['height'])
        assert_equal(best_1['height'], node_height)
        assert_equal(best_1['height'], rpc_height)
        best_0 = self.nodes[0].getbestchainlock()
        assert_equal(best_0['blockhash'], best_1['blockhash'])
        assert_equal(best_0['height'], best_1['height'])
        assert_equal(best_0['signature'], best_1['signature'])
        assert_equal(best_0['known_block'], False)
        self.reconnect_isolated_node(0, 1)
        self.sync_all()

        self.log.info("Isolate node, mine on both parts of the network, and reconnect")
        self.isolate_node(0)
        bad_tip = self.generate(self.nodes[0], 5, sync_fun=self.no_op)[-1]
        self.generatetoaddress(self.nodes[1], 1, node0_mining_addr, sync_fun=self.no_op)
        good_tip = self.nodes[1].getbestblockhash()
        self.wait_for_chainlocked_block(self.nodes[1], good_tip)
        assert not self.nodes[0].getblock(self.nodes[0].getbestblockhash())["chainlock"]
        self.reconnect_isolated_node(0, 1)
        self.generatetoaddress(self.nodes[1], 1, node0_mining_addr, sync_fun=self.no_op)
        self.wait_for_chainlocked_block_all_nodes(self.nodes[1].getbestblockhash())
        self.test_coinbase_best_cl(self.nodes[0])
        assert self.nodes[0].getblock(self.nodes[0].getbestblockhash())["previousblockhash"] == good_tip
        assert self.nodes[1].getblock(self.nodes[1].getbestblockhash())["previousblockhash"] == good_tip

        self.log.info("The tip mined while this node was isolated should be marked conflicting now")
        found = False
        for tip in self.nodes[0].getchaintips(2):
            if tip["hash"] == bad_tip:
                assert tip["status"] == "conflicting"
                found = True
                break
        assert found

        self.log.info("Keep node connected and let it try to reorg the chain")
        good_tip = self.nodes[0].getbestblockhash()
        self.log.info("Restart it so that it forgets all the chainlock messages from the past")
        self.restart_node(0)
        self.connect_nodes(0, 1)
        assert self.nodes[0].getbestblockhash() == good_tip
        self.nodes[0].invalidateblock(good_tip)
        self.log.info("Now try to reorg the chain")
        self.generate(self.nodes[0], 2, sync_fun=self.no_op)
        time.sleep(6)
        assert self.nodes[1].getbestblockhash() == good_tip
        bad_tip = self.generate(self.nodes[0], 2, sync_fun=self.no_op)[-1]
        time.sleep(6)
        assert self.nodes[0].getbestblockhash() == bad_tip
        assert self.nodes[1].getbestblockhash() == good_tip

        self.log.info("Now let the node which is on the wrong chain reorg back to the locked chain")
        self.nodes[0].reconsiderblock(good_tip)
        assert self.nodes[0].getbestblockhash() != good_tip
        good_fork = good_tip
        good_tip = self.generatetoaddress(self.nodes[1], 1, node0_mining_addr, sync_fun=self.no_op)[-1]  # this should mark bad_tip as conflicting
        self.wait_for_chainlocked_block_all_nodes(good_tip)
        self.test_coinbase_best_cl(self.nodes[0])
        assert self.nodes[0].getbestblockhash() == good_tip
        found = False
        for tip in self.nodes[0].getchaintips(2):
            if tip["hash"] == bad_tip:
                assert tip["status"] == "conflicting"
                found = True
                break
        assert found

        self.log.info("Should switch to the best non-conflicting tip (not to the most work chain) on restart")
        assert int(self.nodes[0].getblock(bad_tip)["chainwork"], 16) > int(self.nodes[1].getblock(good_tip)["chainwork"], 16)
        self.restart_node(0)
        self.nodes[0].invalidateblock(good_fork)
        self.restart_node(0)
        time.sleep(1)
        assert self.nodes[0].getbestblockhash() == good_tip

        self.log.info("Isolate a node and let it create some transactions which won't get IS locked")
        force_finish_mnsync(self.nodes[0])
        self.isolate_node(0)
        txs = []
        for _ in range(3):
            txs.append(self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1))
        txs += self.create_chained_txs(self.nodes[0], 1)
        self.log.info("Assert that after block generation these TXs are NOT included (as they are \"unsafe\")")
        node0_tip = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[-1]
        for txid in txs:
            tx = self.nodes[0].getrawtransaction(txid, 1)
            assert "confirmations" not in tx
        time.sleep(1)
        node0_tip_block = self.nodes[0].getblock(node0_tip)
        assert not node0_tip_block["chainlock"]
        assert node0_tip_block["previousblockhash"] == good_tip
        self.log.info("Disable LLMQ based InstantSend for a very short time (this never gets propagated to other nodes)")
        self.nodes[0].sporkupdate("SPORK_2_INSTANTSEND_ENABLED", 4070908800)
        self.log.info("Now the TXs should be included")
        self.generate(self.nodes[0], 1, sync_fun=self.no_op)
        self.nodes[0].sporkupdate("SPORK_2_INSTANTSEND_ENABLED", 0)
        self.log.info("Assert that TXs got included now")
        for txid in txs:
            tx = self.nodes[0].getrawtransaction(txid, 1)
            assert "confirmations" in tx and tx["confirmations"] > 0
        # Enable network on first node again, which will cause the blocks to propagate and IS locks to happen retroactively
        # for the mined TXs, which will then allow the network to create a CLSIG
        self.log.info("Re-enable network on first node and wait for chainlock")
        self.reconnect_isolated_node(0, 1)
        self.wait_for_chainlocked_block(self.nodes[0], self.nodes[0].getbestblockhash(), timeout=30)

        for i in range(2):
            self.log.info(f"{'Disable' if i == 0 else 'Enable'} Chainlock")
            self.nodes[0].sporkupdate("SPORK_19_CHAINLOCKS_ENABLED", 4070908800 if i == 0 else 0)
            self.wait_for_sporks_same()

            self.log.info("Add a new node and let it sync")
            self.dynamically_add_masternode(evo=False)
            added_idx = len(self.nodes) - 1
            assert_raises_rpc_error(-32603, "Unable to find any ChainLock", self.nodes[added_idx].getbestchainlock)

            self.log.info("Test that new node can mine without Chainlock info")
            tip_0 = self.nodes[0].getblock(self.nodes[0].getbestblockhash(), 2)
            self.generate(self.nodes[added_idx], 1, sync_fun=lambda: self.sync_blocks())
            tip_1 = self.nodes[0].getblock(self.nodes[0].getbestblockhash(), 2)
            assert_equal(tip_1['cbTx']['bestCLSignature'], tip_0['cbTx']['bestCLSignature'])
            assert_equal(tip_1['cbTx']['bestCLHeightDiff'], tip_0['cbTx']['bestCLHeightDiff'] + 1)

        self.log.info("Test bestCLHeightDiff restrictions")
        self.test_bestCLHeightDiff()

    def create_chained_txs(self, node, amount):
        txid = node.sendtoaddress(node.getnewaddress(), amount)
        tx = node.getrawtransaction(txid, 1)
        inputs = []
        valueIn = 0
        for txout in tx["vout"]:
            inputs.append({"txid": txid, "vout": txout["n"]})
            valueIn += txout["value"]
        outputs = {
            node.getnewaddress(): round(float(valueIn) - 0.0001, 6)
        }

        rawtx = node.createrawtransaction(inputs, outputs)
        rawtx = node.signrawtransactionwithwallet(rawtx)
        rawtxid = node.sendrawtransaction(rawtx["hex"])

        return [txid, rawtxid]

    def test_coinbase_best_cl(self, node, expected_cl_in_cb=True, expected_null_cl=False):
        block_hash = node.getbestblockhash()
        block = node.getblock(block_hash, 2)
        cbtx = block["cbTx"]
        assert_equal(int(cbtx["version"]) > 2, expected_cl_in_cb)
        if expected_cl_in_cb:
            cb_height = int(cbtx["height"])
            best_cl_height_diff = int(cbtx["bestCLHeightDiff"])
            best_cl_signature = cbtx["bestCLSignature"]
            assert_equal(expected_null_cl, int(best_cl_signature, 16) == 0)
            if expected_null_cl:
                # Null bestCLSignature is allowed.
                # bestCLHeightDiff must be 0 if bestCLSignature is null
                assert_equal(best_cl_height_diff, 0)
                # Returning as no more tests can be conducted
                return
            best_cl_height = cb_height - best_cl_height_diff - 1
            target_block_hash = node.getblockhash(best_cl_height)
            # Verify CL signature
            assert node.verifychainlock(target_block_hash, best_cl_signature, best_cl_height)
        else:
            assert "bestCLHeightDiff" not in cbtx and "bestCLSignature" not in cbtx

    def test_bestCLHeightDiff(self):
        # We need 2 blocks we can grab clsigs from
        for _ in range(2):
            self.wait_for_chainlocked_block_all_nodes(self.generate(self.nodes[0], 1, sync_fun=self.no_op)[0])
        tip1_hash = self.nodes[1].getbestblockhash()

        self.isolate_node(1)
        tip0_hash = self.generate(self.nodes[0], 1, sync_fun=self.no_op)[0]
        block_hex = self.nodes[0].getblock(tip0_hash, 0)
        mal_block = CBlock()
        mal_block.deserialize(BytesIO(bytes.fromhex(block_hex)))
        cbtx = CCbTx()
        cbtx.deserialize(BytesIO(mal_block.vtx[0].vExtraPayload))
        assert_equal(cbtx.bestCLHeightDiff, 0)

        cbtx.bestCLHeightDiff = 1
        mal_block.vtx[0].vExtraPayload = cbtx.serialize()
        mal_block.vtx[0].rehash()
        mal_block.hashMerkleRoot = mal_block.calc_merkle_root()
        mal_block.solve()
        result = self.nodes[1].submitblock(mal_block.serialize().hex())
        assert_equal(result, "bad-cbtx-invalid-clsig")
        assert_equal(self.nodes[1].getbestblockhash(), tip1_hash)

        # Update the sig too and it should pass now
        cbtx.bestCLSignature = bytes.fromhex(self.nodes[1].getblock(tip1_hash, 2)["tx"][0]["cbTx"]["bestCLSignature"])
        mal_block.vtx[0].vExtraPayload = cbtx.serialize()
        mal_block.vtx[0].rehash()
        mal_block.hashMerkleRoot = mal_block.calc_merkle_root()
        mal_block.solve()
        result = self.nodes[1].submitblock(mal_block.serialize().hex())
        assert_equal(result, None)
        assert not self.nodes[1].getbestblockhash() == tip1_hash

        # Revert to test another use case
        self.nodes[1].invalidateblock(self.nodes[1].getbestblockhash())
        assert_equal(self.nodes[1].getbestblockhash(), tip1_hash)

        # Now it's too old but fails because of another reason when mn_rr is active
        cbtx.bestCLHeightDiff = 2
        mal_block.vtx[0].vExtraPayload = cbtx.serialize()
        mal_block.vtx[0].rehash()
        mal_block.hashMerkleRoot = mal_block.calc_merkle_root()
        mal_block.solve()
        result = self.nodes[1].submitblock(mal_block.serialize().hex())
        assert_equal(result, "bad-cbtx-older-clsig")
        assert_equal(self.nodes[1].getbestblockhash(), tip1_hash)

        # Update the sig too and it should fail
        old_blockhash = self.nodes[1].getblockhash(self.nodes[1].getblockcount() - 1)
        cbtx.bestCLSignature = bytes.fromhex(self.nodes[1].getblock(old_blockhash, 2)["tx"][0]["cbTx"]["bestCLSignature"])
        mal_block.vtx[0].vExtraPayload = cbtx.serialize()
        mal_block.vtx[0].rehash()
        mal_block.hashMerkleRoot = mal_block.calc_merkle_root()
        mal_block.solve()
        result = self.nodes[1].submitblock(mal_block.serialize().hex())
        assert_equal(result, "bad-cbtx-older-clsig")
        assert_equal(self.nodes[1].getbestblockhash(), tip1_hash)

        self.reconnect_isolated_node(1, 0)
        self.sync_all()


if __name__ == '__main__':
    LLMQChainLocksTest().main()