Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'findNewAuthorities()' #375

Closed
3 tasks
Patrick-Erichsen opened this issue Apr 7, 2020 · 3 comments
Closed
3 tasks

Implement 'findNewAuthorities()' #375

Patrick-Erichsen opened this issue Apr 7, 2020 · 3 comments

Comments

@Patrick-Erichsen
Copy link
Contributor

Patrick-Erichsen commented Apr 7, 2020

I was poking around in the codebase and noticed the commented instructions for building out findNewAuthorities() in LocationTracking.js.

I'm looking for a good first issue to tackle and thought I'd give this a go.

@penrods, it looks like you added the comments. Mind if I assign this to myself?

Outline

  • Pull down the Healthcare Authorities list (see Settings.js)
  • look at the GPS extent box of each authority and (if any of the GPS coordinates change) pop-up a notification that is basically:
    • There is a new "Healthcare Authority" for an area where you have been.
  • Tapping that notification asks if they want to Add that Healthcare Authority under the Settings screen.
@Patrick-Erichsen Patrick-Erichsen changed the title Implement findNewAuthorities Implement 'findNewAuthorities()' Apr 7, 2020
@Patrick-Erichsen
Copy link
Contributor Author

If this work is a blocker on any other issues please let me know - I have experience developing React & React Native Web, but I'm pretty new to React Native and mobile in general. I don't want to hold anything else up if it takes longer than I anticipated.

@Patrick-Erichsen
Copy link
Contributor Author

I spent a few hours today trying to figure out how to test rn-fetch-blog but couldn't get it to work.

I wanted to pull down our list of HCAs and verify that we're returning a valid YAML file that has an Authorities list, but it doesn't seem like there's a clean way to actually call RNFetchBlob in Jest without just mocking out the entire module (wkh237/react-native-fetch-blob#212).

If anyone has any thoughts on how to test this cleanly let me know.

@penrods
Copy link
Contributor

penrods commented Apr 10, 2020

Closing this one in favor of #425.

@penrods penrods closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants