Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put notification if location is not getting logged #50

Closed
tremblerz opened this issue Mar 15, 2020 · 6 comments
Closed

Put notification if location is not getting logged #50

tremblerz opened this issue Mar 15, 2020 · 6 comments
Labels
Bug Something isn't working High Priority High importance / High value Work In Progress Don't merge quite yet, still in progress
Milestone
v2.0

Comments

@tremblerz
Copy link
Contributor

The location might not be getting logged due to the location turned off through settings or some other reason. We need a rigorous way of testing it.
@tremblerz tremblerz added the Bug Something isn't working label Mar 15, 2020
@penrods penrods added the High Priority High importance / High value label Mar 16, 2020
@tushar-dadlani
Copy link
Contributor

How aggressively do you want to notify the user?

@penrods penrods mentioned this issue Mar 16, 2020
Merged
@rparet rparet added this to the v2.0 milestone Mar 22, 2020
@tremblerz
Copy link
Contributor Author

We have push notifications now for iOS. On Android they still don't appear

@darkerthanblackoff darkerthanblackoff mentioned this issue Apr 13, 2020
Merged
@harshvitra harshvitra added the Work In Progress Don't merge quite yet, still in progress label Apr 14, 2020
@penrods
Copy link
Contributor

penrods commented Apr 18, 2020

Still an issue?

@summetj
Copy link
Collaborator

summetj commented Apr 18, 2020

Yes lack of notification is still an issue on android. When running and logging in background, if locations permission is removed, there is no notification. (However, if the app is manually re-started, it detects that it needs to ask for location access again and goes through the "getting started" flow.)

@maher1719
Copy link

Maybe we can find the location with the network tower id who provide mobile signals and check the id with remote tower database

@Shabanisimo
Copy link
Contributor

Shabanisimo commented May 6, 2020 •
edited
Loading

The bug is fixed. #503
Please close the ticket.

@summetj summetj closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working High Priority High importance / High value Work In Progress Don't merge quite yet, still in progress
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
8 participants
@tushar-dadlani @rparet @tremblerz @summetj @penrods @Shabanisimo @maher1719 @harshvitra