Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring up the location data collapse PR changes back #51

Closed
tremblerz opened this issue Mar 15, 2020 · 4 comments
Closed

Bring up the location data collapse PR changes back #51

tremblerz opened this issue Mar 15, 2020 · 4 comments
Labels
Enhancement Enhancing an existing feature or a request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tremblerz
Copy link
Contributor

No description provided.

@tremblerz tremblerz added Enhancement Enhancing an existing feature or a request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 15, 2020
@tremblerz
Copy link
Contributor Author

See the changes proposed in LocationTracking.js https://github.com/tripleblindmarket/private-kit/pull/35/files

@tushar-dadlani
Copy link
Contributor

can you provide some more examples? This looks like a UI/UX change.

@penrods
Copy link
Contributor

penrods commented Mar 15, 2020

That code got lost in PR merge when the GPS point "curate" code moved from views/LocationTracking.js to services/LocationService.js. The curate was in PR #35 in the new lines from 70-85: https://github.com/tripleblindmarket/private-kit/pull/35/files#diff-727aee301c7a491d08372f19508dfde6R70

If you can tackle it in the next little bit I'll review. Otherwise I'll go after it myself.

@penrods
Copy link
Contributor

penrods commented Mar 16, 2020

Fixed by #55

@penrods penrods closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Enhancing an existing feature or a request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tushar-dadlani @tremblerz @penrods