Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the timing issue #4

Closed
gunesacar opened this issue Nov 23, 2023 · 4 comments
Closed

Address the timing issue #4

gunesacar opened this issue Nov 23, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@gunesacar
Copy link

We seem to miss early calls to Topics API. Let's follow Privacy Badger's example to solve it:
https://groups.google.com/a/chromium.org/g/chromium-extensions/c/jU3Ib6fP9A8/m/qsLz0HcnAwAJ
https://github.com/EFForg/privacybadger/blob/4b8c4655a4d46c900df99f9837c998bf67d51133/src/js/contentscripts/utils.js#L18-L37

@Paul2803k Paul2803k added the bug Something isn't working label Nov 24, 2023
@Paul2803k
Copy link
Owner

I have noticed that the proposed solution raises a CSP infringement in some websites such as https://www.vuecinemas.nl/#filmposters.
These websites seem to completely prohibit any inline script. I wonder how they played around it...
Here is a screenshot of the error:
image
To mitigate the issue I have injected the script as a Blob since it seems to help getting around a few of these restrictions. Some still stand. Any suggestion at the top of your head @gunesacar?
On the other hand, the timing issue seems to be fixed.

@gunesacar
Copy link
Author

Any suggestion at the top of your head @gunesacar?

Unfortunately none, but a search for CSP violation Privacy Badger or uBlock Origin yields interesting results:
EFForg/privacybadger#1793

@gunesacar
Copy link
Author

Just to be clear, I think this is a low priority issue and can be stated as a limitation if a clean workaround cannot be found. What we don't want is to interfere with the websites' CSP policies, for example. Thanks for identifying this bug in the first place!

@Paul2803k
Copy link
Owner

Paul2803k commented Nov 24, 2023

I agree, I will give it some thought but it definitely shouldn't delay the wrap-up. As you mention, this is an interesting limitation that a lot of extensions face.

Just to be clear, I think this is a low priority issue and can be stated as a limitation if a clean workaround cannot be found. What we don't want is to interfere with the websites' CSP policies, for example. Thanks for identifying this bug in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants