Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library is not working with IE10 , v0.12.1 , but v0.11.7 is fine #215

Closed
aparij opened this issue Aug 31, 2016 · 6 comments · Fixed by #235
Closed

The library is not working with IE10 , v0.12.1 , but v0.11.7 is fine #215

aparij opened this issue Aug 31, 2016 · 6 comments · Fixed by #235

Comments

@aparij
Copy link

aparij commented Aug 31, 2016

Looks like the changes in v.0.12.0 moving from props to context broke it on IE10.
It works fine with v0.11.7

The map is not initialized

The error message is :
ReactCompositeComponent.getChildContext(): childContextTypes must be defined in order to use getChildContext().

You can run the react-leaflet examples locally and see that none are working .

Not sure why the thing is not working. Babel should properly transpile from the ES7 static childContextTypes

@aparij aparij changed the title The library is not working with IE10 , v0.12.1 The library is not working with IE10 , v0.12.1 , but v0.11.7 is fine Aug 31, 2016
@PaulLeCam
Copy link
Owner

Apparently IE <= 10 does not support proto so IE <= 10 isn't be supported by React-Leaflet from v0.12

@aparij
Copy link
Author

aparij commented Sep 1, 2016

Or you can add babel-polyfill to the dependencies.

@PaulLeCam
Copy link
Owner

If it works with babel-polyfill, why don't you add it to your app?

@aparij
Copy link
Author

aparij commented Sep 1, 2016

Well, the thing is I have it and it still doesn't work. Anyways I don't think adding babel-polyfill will help in this case, it's something else.

@dettier
Copy link
Contributor

dettier commented Oct 11, 2016

This is the reason it doesn't work in IE <= 10: https://babeljs.io/docs/usage/caveats/
You can just add protoToAssign and loose options in babel configuration to fix this.
babel-polyfill won't help with this one.

@webcarrot
Copy link

Version 2.0 work in IE >= 9 with https://www.npmjs.com/package/proto-polyfill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants