Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild regional filtering to be dependant on data #219

Open
mackh opened this issue Sep 30, 2016 · 0 comments
Open

Rebuild regional filtering to be dependant on data #219

mackh opened this issue Sep 30, 2016 · 0 comments
Assignees

Comments

@mackh
Copy link
Collaborator

mackh commented Sep 30, 2016

Currently the regional filter on the app is dependant on hardcoded values in the codebase as well as polygon values from the polygon.json file.

The filters look for point locations in the polygons, which is unnessecary.

https://github.com/PeaceGeeksSociety/services-advisor/blob/master/src/angular/Services/search.js#L107-L125

https://github.com/PeaceGeeksSociety/services-advisor/blob/master/src/polygons.json?short_path=14b816f

Refactor the filter to work based on data from the services.json in the Region item, and make it bahavelike the category filter - http://admin.jordan.servicesadvisor.org/service-locations

The region field in the json feed has an error in it, Smith is working to correct this

Remove the code that is calulating the Distrcit membership found here -

Remove District names from the translation files here https://github.com/PeaceGeeksSociety/services-advisor/blob/master/src/angular/translations/translations.config.js#L40-L51 and https://github.com/PeaceGeeksSociety/services-advisor/blob/master/src/angular/translations/translations.config.js#L96-L108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants