diff --git a/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/condition/net/ExpectNetServicesReturnsAllServicesAsActive.java b/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/condition/net/ExpectNetServicesReturnsAllServicesAsActive.java index bf7ab10650..f23d68b6c9 100644 --- a/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/condition/net/ExpectNetServicesReturnsAllServicesAsActive.java +++ b/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/condition/net/ExpectNetServicesReturnsAllServicesAsActive.java @@ -42,10 +42,12 @@ public void verify(final Node node) { assertThat(InetAddresses.isUriInetAddress(result.get("ws").get("host"))).isTrue(); final int wsPort = Integer.valueOf(result.get("ws").get("port")); + // TODO: explicitly set port assertThat(NetworkUtility.isValidPort(wsPort) || wsPort == 0).isTrue(); assertThat(InetAddresses.isUriInetAddress(result.get("jsonrpc").get("host"))).isTrue(); final int jsonRpcPort = Integer.valueOf(result.get("jsonrpc").get("port")); + // TODO: explicitly set port assertThat(NetworkUtility.isValidPort(jsonRpcPort) || jsonRpcPort == 0).isTrue(); } diff --git a/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/transaction/NetServicesJsonRpcRequestFactory.java b/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/transaction/NetServicesJsonRpcRequestFactory.java index f2320946b3..1ac592855f 100644 --- a/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/transaction/NetServicesJsonRpcRequestFactory.java +++ b/acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/transaction/NetServicesJsonRpcRequestFactory.java @@ -32,10 +32,7 @@ public NetServicesJsonRpcRequestFactory(final Web3jService web3jService) { public Request netServices() { - final Request request = - new Request<>( - "net_services", Collections.EMPTY_LIST, web3jService, NetServicesResponse.class); - - return request; + return new Request<>( + "net_services", Collections.EMPTY_LIST, web3jService, NetServicesResponse.class); } }