From fde901f999f4f9eedf7e26b963818504e22a9fb1 Mon Sep 17 00:00:00 2001 From: Christopher Mckay Date: Fri, 26 Oct 2018 10:19:15 +1000 Subject: [PATCH 1/2] [MINOR] Javadoc warnings are errors --- build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/build.gradle b/build.gradle index 881ee71211..7759d78592 100644 --- a/build.gradle +++ b/build.gradle @@ -203,6 +203,7 @@ allprojects { // Normalise Xdoclint behaviour across JDKs (OpenJDK 8 is more lenient than Oracle JDK by default). javadoc { options.addStringOption('Xdoclint:all', '-quiet') + options.addStringOption('Xwerror', '-quiet') options.encoding = 'UTF-8' } From 0e7e864092f0b1b84bf5cc4c6f2371d973fc8cbe Mon Sep 17 00:00:00 2001 From: Christopher Mckay Date: Fri, 26 Oct 2018 22:56:56 +1000 Subject: [PATCH 2/2] use valid flags for the right java versions --- build.gradle | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 7759d78592..68e54b8412 100644 --- a/build.gradle +++ b/build.gradle @@ -203,7 +203,11 @@ allprojects { // Normalise Xdoclint behaviour across JDKs (OpenJDK 8 is more lenient than Oracle JDK by default). javadoc { options.addStringOption('Xdoclint:all', '-quiet') - options.addStringOption('Xwerror', '-quiet') + if (JavaVersion.current() == JavaVersion.VERSION_1_8) { + options.addStringOption('Xwerror', '-quiet') + } else { + options.addStringOption('Xwerror', '-html5') + } options.encoding = 'UTF-8' }