-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR documentation builds #42
Comments
@josh146, do we still need something in |
@trbromley, with the new device, is this issue now closed? |
@josh146 we still have MOCK_DOCS in Could we remove |
I believe you can now share env variables with PR builds: readthedocs/readthedocs.org#7182 (comment). Will have a go! |
Docs now build in each PR. Closing. |
Currently, if the environment variable
MOCK_DOCS
is set, thesetup.py
file will skip the building of the wheels. This is required for ReadTheDocs, where C++ extensions cannot be built.Unfortunately, ReadTheDocs environment variables are not passed to PRs and forks, so we cannot activate the option to build the docs for PRs. An alternative option would be to simply mock out the C++ extensions in the
conf.py
file, like we do for The Walrus.The text was updated successfully, but these errors were encountered: