Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things are very slow to load in Binder because it is having to deal with so many images in the .ipynb files #43

Open
altanner opened this issue Jul 11, 2023 · 2 comments

Comments

@altanner
Copy link

Problem: Using links such as this in the docs leads to a very slow loadup of Binder.

Diagnosis: Binder's console says it is slow because the repo is congested with >400 MB of images held in the Jupyter Notebooks, each of which gets transmitted and processed by Binder.

Solution: Tidy up the notebooks. Edit down image count in docs.

@PennyWieser
Copy link
Owner

Hi Alistair,
Thanks for taking a look. I wasnt even aware I had made a binder (where did you find that link?). It must be a hang over from another project I ported the structure over from.
I'm not really sure how to address this - I want users to be able to view all of the spectral fits as they are fitting them, and of course its image heavy. Perhaps this isnt a code that binder makes sense for - if people want to look at examples they have the read the docs page - given the large amount of image generation. This can be turned off with commands in the functions, but for the examples I have kept them to demonstrate.
Any other suggestiosn welcome!

@PennyWieser
Copy link
Owner

PennyWieser commented Jul 11, 2023

Oh I see you mean the badge for each read the docs example (Defo a hang over from a previous project haha). Did you look at example 1a? It is fitting a lot of spectra, so that is a particularly bad one. Or when binder is launched, is it launching all the notebooks, not just the one you select?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants