Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request for msys2/mingw64 build #84

Open
hgkamath opened this issue Jun 25, 2020 · 4 comments
Open

request for msys2/mingw64 build #84

hgkamath opened this issue Jun 25, 2020 · 4 comments

Comments

@hgkamath
Copy link

hgkamath commented Jun 25, 2020

I notice that there is a WSL build.
WSL, for some, its hypervisor/vm/linux subsystem may be too much. same can be said of a cygwin build.

Since release of windows-10 1903, microsoft introduced a new API conpty for linux-like pseudoterminals to phase out the older conhost. The recently released windows terminal also uses the conpty approach.
Some tools like vim, do seem to support the new conpty. msys/cygwin seem to be attempting conpty around the 3.1.5 version.

I think it should be within reach to have a msys/mingw64 build for domterm.exe and domterm-qt.exe
Hence the suggestion/request.

@PerBothner
Copy link
Owner

I agree this would be nice, and I would support it. However, there are some other "big-ticket" items on the roadmap that I'm focusing on before native-Windows support. If someone where to contribute it, it would be great.

There is an experimental "pure-Electron" version of DomTerm which might be easier to port to native Windows. An alternative I'm also keeping an eye on is Deno, perhaps combined with deno-webview - but that is too early.

@PerBothner
Copy link
Owner

I added some instructions for building and using electron-nodepty, after verifying that it works on plain (non-WSL) Windows (after fixing a couple of issues).

@cebaa
Copy link

cebaa commented Sep 2, 2020

@PerBothner Just one note regarding electron-nodepty and builds in general (on Windows at least). Looks like the build requires installing Visual Studio. In many cases, installation is not even possible (e.g. no admin privileges). Having pre-built binaries is a life-saver in such cases (and also brings a bunch of other niceties). Not sure if possible and how demanding it would be to set up github actions that would build these on release.

@PerBothner
Copy link
Owner

"Looks like the build requires installing Visual Studio."

I assume that is because of the node-pty package.

I agree pre-built binaries would be very nice, but that's a lot of new stuff I (or someone else) would have to master. For Windows we have the issue of either getting the C-domterm working without WSL or beefing up electron-nodepty. (Longer-term, I'm watching Deno with interest.)

I'd love to have help with these things, but for now I don't have the time.

@PerBothner PerBothner mentioned this issue Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants