[PATCH] Fix missing single quote in hints/aix.sh #13118

p5pRT · 2013-07-21T22:50:50Z

Migrated from rt.perl.org#118961 (status was 'resolved')

Searchable as RT118961$

p5pRT · 2013-07-21T22:50:50Z

From [email protected]

This is a bug report for perl from petercmartini@gmail.com
-----------------------------------------------------------------

I had quite a bit of a headache trying to do a build on AIX due to a
single missing single quote (it wiped out ccflags!). Depending on the
version of shell and sed I used, which made it even more of a headache
to find.

Patch attached to make things saner.

Also, if this could be ported, I'd appreciate it.

Perl Info


Flags:
    category=core
    severity=low

Site configuration information for perl 5.19.1:

Configured by pmartini at Fri Jan 25 00:20:08 EST 2013.

Summary of my perl5 (revision 5 version 19 subversion 2) configuration:
  Commit id: de5c37d7b71464603fe7ccc9be2d47de77a38e9e
  Platform:
    osname=linux, osvers=3.2.0-38-generic, archname=i686-linux-thread-multi
    uname='linux pmlinlaptop 3.2.0-38-generic #61-ubuntu smp tue feb
19 12:20:02 utc 2013 i686 i686 i386 gnulinux '
    config_args='-Dusedevel -DDEBUGGING -Dusethreads -des'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include
-D_LA
RGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -g',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.6.3', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /lib/i386-linux-gnu /lib/../lib
/usr/lib/i386-linux-gnu /usr/lib/../lib /lib /usr/lib
    libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.15'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib
-fstack-protector'

Characteristics of this binary (from libperl):
  Compile-time options: DEBUGGING HAS_TIMES MULTIPLICITY PERLIO_LAYERS
                        PERL_DONT_CREATE_GVSV
                        PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
                        PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
                        PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
                        PERL_TRACK_MEMPOOL PERL_USE_DEVEL USE_ITHREADS
                        USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
                        USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO
                        USE_PERL_ATOF USE_REENTRANT_API
  Built under linux
  Compiled at Jun 27 2013 21:33:59
  %ENV:
    PERL5LIB="/home/pmartini/perl5/lib/perl5:"
    PERL_LOCAL_LIB_ROOT=":/home/pmartini/perl5"
    PERL_MB_OPT="--install_base /home/pmartini/perl5"
    PERL_MM_OPT="INSTALL_BASE=/home/pmartini/perl5"
  @INC:
    lib
    /home/pmartini/perl5/lib/perl5/i686-linux-thread-multi
    /home/pmartini/perl5/lib/perl5
    /usr/local/lib/perl5/site_perl/5.19.2/i686-linux-thread-multi
    /usr/local/lib/perl5/site_perl/5.19.2
    /usr/local/lib/perl5/5.19.2/i686-linux-thread-multi
    /usr/local/lib/perl5/5.19.2
    /usr/local/lib/perl5/site_perl
    .

p5pRT · 2013-07-21T22:50:50Z

From [email protected]

0001-Fix-missing-single-quote-in-a-sed-in-hints-aix.sh.patch

From ed960dc2d1d95439e225c5e6b9a34f6d0cad0e97 Mon Sep 17 00:00:00 2001
From: Peter Martini <[email protected]>
Date: Sun, 21 Jul 2013 18:45:45 -0400
Subject: [PATCH] Fix missing single quote in a sed in hints/aix.sh

---
 hints/aix.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hints/aix.sh b/hints/aix.sh
index e1ae2fd..675cfa6 100644
--- a/hints/aix.sh
+++ b/hints/aix.sh
@@ -342,7 +342,7 @@ libswanted_uselargefiles="`getconf XBS5_ILP32_OFFBIG_LIBS 2>/dev/null|sed -e 's@
 		    esac
                 # Some 32-bit getconfs will set ccflags to include -qlonglong
                 # but that's no longer needed with an explicit -qextc99.
-                ccflags="`echo $ccflags | sed -e 's@ -qlonglong@@`"
+                ccflags="`echo $ccflags | sed -e 's@ -qlonglong@@'`"
 		;;
 	    *)  # Remove xlc-specific -qflags.
 		ccflags="`echo $ccflags | sed -e 's@ -q[^ ]*@ @g' -e 's@^-q[^ ]* @@g'`"
-- 
1.7.0.3

p5pRT · 2013-07-22T00:22:06Z

From @jkeenan

On Sun Jul 21 15:50:50 2013, pcm wrote:

This is a bug report for perl from petercmartini@gmail.com
-----------------------------------------------------------------

I had quite a bit of a headache trying to do a build on AIX due to a
single missing single quote (it wiped out ccflags!). Depending on the
version of shell and sed I used, which made it even more of a headache
to find.

Patch attached to make things saner.

Also, if this could be ported, I'd appreciate it.

I'll apply this to blead as soon as (a) 'make test' completes and (b) I
know I can do so without interfering with the monthly release. I will
leave the porting question to those who know more about that than I do.

Thank you very much.
Jim Keenan

p5pRT · 2013-07-22T00:22:07Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2013-07-22T05:50:41Z

From @Tux

On Sun, 21 Jul 2013 17:22:07 -0700, "James E Keenan via RT"
<perlbug-followup@perl.org> wrote:

On Sun Jul 21 15:50:50 2013, pcm wrote:

This is a bug report for perl from petercmartini@gmail.com
-----------------------------------------------------------------

I had quite a bit of a headache trying to do a build on AIX due to a
single missing single quote (it wiped out ccflags!). Depending on the
version of shell and sed I used, which made it even more of a headache
to find.

Patch attached to make things saner.

Also, if this could be ported, I'd appreciate it.

I'll apply this to blead as soon as (a) 'make test' completes and (b) I
know I can do so without interfering with the monthly release. I will
leave the porting question to those who know more about that than I do.

I'd say apply now. This is an obvious mistake that only applies to AIX.
My AIX smoker never hit this.

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

p5pRT · 2013-07-22T06:22:19Z

From @Tux

On Sun, 21 Jul 2013 15:50:50 -0700, Peter Martini (via RT)
<perlbug-followup@perl.org> wrote:

I had quite a bit of a headache trying to do a build on AIX due to a
single missing single quote (it wiped out ccflags!). Depending on the
version of shell and sed I used, which made it even more of a headache
to find.

And it is in a CBU, not even in the Configure base code or directly run
hints. I feel your pain :)

Looks like it was my mistake in committing Darins patch:

commit 9d7bf48
Author: Darin McBride <dmcbride@cpan.org>
Date: Mon Jun 25 17:36:32 2012 -0600

Patch attached to make things saner.

Patch looks good, as I already replied to Jim, but your perl -V is from
Linux, not from AIX, so I cannot spot the difference between a working
AIX conf and your situation to see why my AIX never hit this.

Also, if this could be ported, I'd appreciate it.

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
category=core
severity=low
---
Site configuration information for perl 5.19.1:

Configured by pmartini at Fri Jan 25 00:20:08 EST 2013.

Summary of my perl5 (revision 5 version 19 subversion 2) configuration:
Commit id: de5c37d7b71464603fe7ccc9be2d47de77a38e9e
Platform:
osname=linux, osvers=3.2.0-38-generic, archname=i686-linux-thread-multi
uname='linux pmlinlaptop 3.2.0-38-generic #61-ubuntu smp tue feb
19 12:20:02 utc 2013 i686 i686 i386 gnulinux '
config_args='-Dusedevel -DDEBUGGING -Dusethreads -des'
hint=recommended, useposix=true, d_sigaction=define
useithreads=define, usemultiplicity=define
useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
use64bitint=undef, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include
-D_LA
RGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
optimize='-O2 -g',
cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING
-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
ccversion='', gccversion='4.6.3', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
alignbytes=4, prototype=define
Linker and Libraries:
ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
libpth=/usr/local/lib /lib/i386-linux-gnu /lib/../lib
/usr/lib/i386-linux-gnu /usr/lib/../lib /lib /usr/lib
libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
libc=, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.15'
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib
-fstack-protector'

Characteristics of this binary (from libperl):
Compile-time options: DEBUGGING HAS_TIMES MULTIPLICITY PERLIO_LAYERS
PERL_DONT_CREATE_GVSV
PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
PERL_TRACK_MEMPOOL PERL_USE_DEVEL USE_ITHREADS
USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO
USE_PERL_ATOF USE_REENTRANT_API
Built under linux
Compiled at Jun 27 2013 21:33:59
%ENV:
PERL5LIB="/home/pmartini/perl5/lib/perl5:"
PERL_LOCAL_LIB_ROOT=":/home/pmartini/perl5"
PERL_MB_OPT="--install_base /home/pmartini/perl5"
PERL_MM_OPT="INSTALL_BASE=/home/pmartini/perl5"
@INC:
lib
/home/pmartini/perl5/lib/perl5/i686-linux-thread-multi
/home/pmartini/perl5/lib/perl5
/usr/local/lib/perl5/site_perl/5.19.2/i686-linux-thread-multi
/usr/local/lib/perl5/site_perl/5.19.2
/usr/local/lib/perl5/5.19.2/i686-linux-thread-multi
/usr/local/lib/perl5/5.19.2
/usr/local/lib/perl5/site_perl
.

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

p5pRT · 2013-07-22T13:09:26Z

From [email protected]

On Mon, Jul 22, 2013 at 2:21 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:

Patch looks good, as I already replied to Jim, but your perl -V is from
Linux, not from AIX, so I cannot spot the difference between a working
AIX conf and your situation to see why my AIX never hit this.

I think the problem was I was using a GNU sed instead of the system
default. I think the system default didn't care that it had the
missing closing single quote, but the GNU version does.

p5pRT · 2013-07-22T13:28:15Z

From @Tux

On Mon, 22 Jul 2013 09:08:46 -0400, Peter Martini
<petercmartini@gmail.com> wrote:

On Mon, Jul 22, 2013 at 2:21 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:

Patch looks good, as I already replied to Jim, but your perl -V is from
Linux, not from AIX, so I cannot spot the difference between a working
AIX conf and your situation to see why my AIX never hit this.

I think the problem was I was using a GNU sed instead of the system
default. I think the system default didn't care that it had the
missing closing single quote, but the GNU version does.

AIX 53.0.0/ML12.$ sed --version
GNU sed version 4.1.2
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
to the extent permitted by law.

That is my AIX: AIX 5.3.0.0/ML12 IBM,9115-505 PowerPC_POWER5/1898(2)

Is your system a 32bit or a 64bit box?

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

p5pRT · 2013-07-22T15:02:58Z

From [email protected]

On Mon, Jul 22, 2013 at 9:27 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:

On Mon, 22 Jul 2013 09:08:46 -0400, Peter Martini
<petercmartini@gmail.com> wrote:

On Mon, Jul 22, 2013 at 2:21 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:

Patch looks good, as I already replied to Jim, but your perl -V is from
Linux, not from AIX, so I cannot spot the difference between a working
AIX conf and your situation to see why my AIX never hit this.

I think the problem was I was using a GNU sed instead of the system
default. I think the system default didn't care that it had the
missing closing single quote, but the GNU version does.

AIX 53.0.0/ML12.$ sed --version
GNU sed version 4.1.2
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
to the extent permitted by law.

That is my AIX: AIX 5.3.0.0/ML12 IBM,9115-505 PowerPC_POWER5/1898(2)

Is your system a 32bit or a 64bit box?

64bit. I think I've found the problem now, not the sed but the shell.
I still can't confirm it right now, but I believe Configure may have
been running under bash instead of the native sh, and *that* makes
sense:

bash:
a=`echo test | sed -e 's@ -qlonglong@@`
bash: command substitution: line 1: unexpected EOF while looking for
matching `''
bash: command substitution: line 2: syntax error: unexpected end of file
/bin/sh:
a=`echo test | sed -e 's@ -qlonglong@@`

just fine

Why that might be the case on this box, I won't speculate :-)

p5pRT · 2013-07-23T00:00:18Z

From @jkeenan

On Sun Jul 21 22:50:41 2013, hmbrand wrote:

On Sun, 21 Jul 2013 17:22:07 -0700, "James E Keenan via RT"
<perlbug-followup@perl.org> wrote:

On Sun Jul 21 15:50:50 2013, pcm wrote:

This is a bug report for perl from petercmartini@gmail.com
-----------------------------------------------------------------

I had quite a bit of a headache trying to do a build on AIX due to a
single missing single quote (it wiped out ccflags!). Depending on the
version of shell and sed I used, which made it even more of a headache
to find.

Patch attached to make things saner.

Also, if this could be ported, I'd appreciate it.

I'll apply this to blead as soon as (a) 'make test' completes and (b) I
know I can do so without interfering with the monthly release. I will
leave the porting question to those who know more about that than I do.

I'd say apply now. This is an obvious mistake that only applies to AIX.
My AIX smoker never hit this.

If anyone else can apply Peter's patch to blead, please do so now.
Apart from dromedary being down, something has happened to my commit bit
and I cannot currently push to origin.

Thank you very much.
Jim Keenan

p5pRT · 2013-07-23T00:42:53Z

From @khwilliamson

Thanks, applied as
da46ab3
--
Karl Williamson

p5pRT · 2013-07-23T00:42:54Z

@khwilliamson - Status changed from 'open' to 'resolved'

p5pRT closed this as completed Jul 23, 2013

p5pRT added Severity Low hasPatch labels Oct 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH] Fix missing single quote in hints/aix.sh #13118

[PATCH] Fix missing single quote in hints/aix.sh #13118

p5pRT commented Jul 21, 2013

p5pRT commented Jul 21, 2013

p5pRT commented Jul 21, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

p5pRT commented Jul 23, 2013

p5pRT commented Jul 23, 2013

p5pRT commented Jul 23, 2013

[PATCH] Fix missing single quote in hints/aix.sh #13118

[PATCH] Fix missing single quote in hints/aix.sh #13118

Comments

p5pRT commented Jul 21, 2013

p5pRT commented Jul 21, 2013

From [email protected]

p5pRT commented Jul 21, 2013

From [email protected]

p5pRT commented Jul 22, 2013

From @jkeenan

p5pRT commented Jul 22, 2013

p5pRT commented Jul 22, 2013

From @Tux

p5pRT commented Jul 22, 2013

From @Tux

p5pRT commented Jul 22, 2013

From [email protected]

p5pRT commented Jul 22, 2013

From @Tux

p5pRT commented Jul 22, 2013

From [email protected]

p5pRT commented Jul 23, 2013

From @jkeenan

p5pRT commented Jul 23, 2013

From @khwilliamson

p5pRT commented Jul 23, 2013