-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.25.7-12-ge03e82a breaks TDRUGEON/List-Pairwise-1.03.tar.gz #15776
Comments
From @andkApologies if this is a duplicate for you, I cannot see that this BBC bisect commit e03e82a add sv_set_undef() API function diagnostics PERL_DL_NONLAZY=1 "/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.7-12-ge03e82a/109d/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t Test Summary Report t/context.t (Wstat: 65280 Tests: 2 Failed: 0) perl -V Summary of my perl5 (revision 5 version 25 subversion 8) configuration: Characteristics of this binary (from libperl): -- |
From @iabynOn Wed, Dec 21, 2016 at 02:14:55PM -0800, Andreas J. Koenig via RT wrote:
Fixed with commit 523e5ba fix (*glob) = () Affected files ... -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sun, 25 Dec 2016 18:04:51 GMT, davem wrote:
Configuring with these options: ##### ... I was able to build blead at this commit: ##### ... and use 'cpanm' to successfully install List::Pairwise. Thank you very much. -- |
@iabyn - Status changed from 'open' to 'resolved' |
From @andkSlaven found another affected module that unfortunately is not fixed by 523e5ba. already closed ticket (maybe can be merged?) [perl #130385] perlbug AutoReply: Bleadperl v5.25.7-12-ge03e82a breaks TDRUGEON/List-Pairwise-1.03.tar.gz also affected ERIKOEST/DNS-LDNS-0.52.tar.gz On Debian requires package libldns-dev. YMMV. perl -V % /home/sand/src/perl/repoperls/installed-perls/host/k93x64xenial/*5.25.7-12-g*/????/bin/perl -V Characteristics of this binary (from libperl): -- |
From @khwilliamsonReopening and merging 130420 into this |
@khwilliamson - Status changed from 'resolved' to 'open' |
From @khwilliamsonOn 12/27/2016 03:58 PM, (Andreas J. Koenig) (via RT) wrote:
This ticket has now been merged with that one, which is reopened.
|
From @jkeenanOn Wed, 28 Dec 2016 00:07:08 GMT, public@khwilliamson.com wrote:
matrix.cpantesters.org doesn't have the report yet, so I'm -- |
From @jkeenanBuilding and testing DNS-LDNS-0.52 Test Summary Report t/dnssec_datachain.t (Wstat: 6400 Tests: 1 Failed: 0) |
From @iabynOn Tue, Dec 27, 2016 at 02:58:06PM -0800, Andreas J. Koenig via RT wrote:
Fixed with the following commit which has just been merged into blead: commit 49b3432 Allow sv = &PL_sv_undef; sv_set_undef(sv) to work Affected files ... Differences ... Inline Patchdiff --git a/sv.c b/sv.c
index e3026f7..83d82fc 100644
--- a/sv.c
+++ b/sv.c
@@ -4808,8 +4808,13 @@ Perl_sv_set_undef(pTHX_ SV *sv)
if (type <= SVt_IV) {
assert(!SvGMAGICAL(sv));
- if (SvREADONLY(sv))
+ if (SvREADONLY(sv)) {
+ /* does undeffing PL_sv_undef count as modifying a read-only
+ * variable? Some XS code does this */
+ if (sv == &PL_sv_undef)
+ return;
Perl_croak_no_modify();
+ }
if (SvROK(sv)) {
if (SvWEAKREF(sv))
-- Wesley Crusher gets beaten up by his classmates for being a smarmy git, |
From @jkeenanOn Wed, 28 Dec 2016 14:19:04 GMT, davem wrote:
Unfortunately, when I configured blead with a somewhat stripped-down version of Andreas's config_args and then tried to install DNS::LDNS via 'cpanm', I still got one test failure. Attaching relevant tail of the build.log and perl -V output. Thank you very much. -- |
From @jkeenanSuccessfully installed Test-Exception-0.43 Test Summary Report t/dnssec_datachain.t (Wstat: 6400 Tests: 1 Failed: 0) |
From @jkeenanSummary of my perl5 (revision 5 version 25 subversion 9) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Wed, 28 Dec 2016 15:12:48 GMT, jkeenan wrote:
I should note, however, that this may be a problem with the module, with its test file, or with some missing prerequisite. The test file has written does not check for definedness of an object before making a method call on that object. ##### If on my machine I throw in a test for definedness immediately after that statement in the test file, the test fails. ##### # Failed test 'result of resolver query is defined' I suspect this failure is independent of the test failures reported earlier by Andreas/Slaven and hence independent of Dave's latest commit. -- |
From @iabynOn Wed, Dec 28, 2016 at 07:23:38AM -0800, James E Keenan via RT wrote:
Looks like a problem with the module's test suite, and nothing to be fixed -- |
@iabyn - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#130385 (status was 'resolved')
Searchable as RT130385$
The text was updated successfully, but these errors were encountered: