Assertion failure in S_make_trie (regcomp.c:2799)

[p5pRT]

Migrated from rt.perl.org#134029 (status was 'resolved')

Searchable as RT134029$

[p5pRT]

From @dur-randir

Created by @dur-randir

While fuzzing perl v5.29.9-63-g2496d8f3f7 built with afl and run
under libdislocator, I found the following program

/\p{upper​:]}|\337(?|ss)|)(?0/

to cause an assertion failure on debugging builds and emit 'Infinite
recursion in regex' on release builds

perl​: regcomp.c​:2799​: I32 S_make_trie(RExC_state_t *, regnode *,
regnode *, regnode *, regnode *, U32, U32, U32)​: Assertion `*uc !=
LATIN_SMALL_LETTER_SHARP_S' failed.

GDB stack trace is following

#0 __GI_raise (sig=sig@​entry=6) at ../sysdeps/unix/sysv/linux/raise.c​:50
#1 0x00007ffff7c25535 in __GI_abort () at abort.c​:79
#2 0x00007ffff7c2540f in __assert_fail_base (fmt=0x7ffff7d87ee0
"%s%s%s​:%u​: %s%sAssertion `%s' failed.\n%n",
  assertion=0x555555a804c0 "*uc != LATIN_SMALL_LETTER_SHARP_S",
file=0x555555a7fcd0 "regcomp.c", line=2799, function=<optimized out>)
at assert.c​:92
#3 0x00007ffff7c330f2 in __GI___assert_fail (assertion=0x555555a804c0
"*uc != LATIN_SMALL_LETTER_SHARP_S", file=0x555555a7fcd0 "regcomp.c",
line=2799,
  function=0x555555a9eb20 <__PRETTY_FUNCTION__.21394> "S_make_trie")
at assert.c​:101
#4 0x000055555568289b in S_make_trie (pRExC_state=0x7fffffffbbd0,
startbranch=0x555555b8023c, first=0x555555b80248, last=0x555555b80264,
  tail=0x555555b80268, word_count=2, flags=39, depth=2) at regcomp.c​:2799
#5 0x000055555569046c in S_study_chunk (pRExC_state=0x7fffffffbbd0,
scanp=0x7fffffffb988, minlenp=0x7fffffffb960, deltap=0x7fffffffb978,
  last=0x555555b80274, data=0x7fffffffbf40, stopparen=0,
recursed_depth=1, and_withp=0x555555b80430, flags=13312, depth=1) at
regcomp.c​:5002
#6 0x000055555569e930 in Perl_re_op_compile (patternp=0x7fffffffc050,
pat_count=1, expr=0x0, eng=0x555555b43d20 <PL_core_reg_engine>,
old_re=0x0,
  is_bare_re=0x0, orig_rx_flags=0, pm_flags=0) at regcomp.c​:8047
#7 0x0000555555696564 in Perl_re_compile (pattern=0x555555b75150,
rx_flags=0) at regcomp.c​:6547
#8 0x00005555556f2a75 in Perl_parse_uniprop_string
(name=0x555555b69783 "upper​:]}|\\337(?|ss)|)(?0", name_len=7,
is_utf8=false, to_fold=false,
  runtime=false, deferrable=true, user_defined_ptr=0x7fffffffc568,
msg=0x555555b75120, level=0) at regcomp.c​:22717
#9 0x00005555556db1c7 in S_regclass (pRExC_state=0x7fffffffd650,
flagp=0x7fffffffcd14, depth=5, stop_at_1=true,
allow_mutiple_chars=false,
  silence_non_portable=false, strict=false, optimizable=true,
ret_invlist=0x0) at regcomp.c​:17104
#10 0x00005555556c5e1d in S_regatom (pRExC_state=0x7fffffffd650,
flagp=0x7fffffffcd14, depth=4) at regcomp.c​:13647
#11 0x00005555556bca5d in S_regpiece (pRExC_state=0x7fffffffd650,
flagp=0x7fffffffce30, depth=3) at regcomp.c​:12457
#12 0x00005555556bc35d in S_regbranch (pRExC_state=0x7fffffffd650,
flagp=0x7fffffffced8, first=1, depth=2) at regcomp.c​:12377
#13 0x00005555556b9b7f in S_reg (pRExC_state=0x7fffffffd650, paren=0,
flagp=0x7fffffffd388, depth=1) at regcomp.c​:12088
#14 0x000055555569d215 in Perl_re_op_compile (patternp=0x0,
pat_count=1, expr=0x555555b7b5e8, eng=0x555555b43d20
<PL_core_reg_engine>, old_re=0x0,
  is_bare_re=0x0, orig_rx_flags=0, pm_flags=0) at regcomp.c​:7705
#15 0x00005555555ba159 in Perl_pmruntime (o=0x555555b7b628,
expr=0x555555b7b5e8, repl=0x0, flags=1, floor=0) at op.c​:7127
#16 0x0000555555670167 in Perl_yyparse (gramtype=258) at perly.y​:1234
#17 0x00005555555ec726 in S_parse_body (env=0x0, xsinit=0x5555555a11f8
<xs_init>) at perl.c​:2531
#18 0x00005555555ea9f8 in perl_parse (my_perl=0x555555b4e260,
xsinit=0x5555555a11f8 <xs_init>, argc=2, argv=0x7fffffffe1c8, env=0x0)
at perl.c​:1822
#19 0x00005555555a113b in main (argc=2, argv=0x7fffffffe1c8,
env=0x7fffffffe1e0) at perlmain.c​:126

This is a regression in blead, bisect points to

commit 1532347
Author​: Karl Williamson <khw@​cpan.org>
Date​: Mon Mar 11 17​:16​:34 2019 -0600

  Add Unicode property wildcards

Perl Info

Flags:
    category=core
    severity=medium

Site configuration information for perl 5.29.9:

Configured by dur-randir at Wed Feb 27 14:51:01 MSK 2019.

Summary of my perl5 (revision 5 version 29 subversion 9) configuration:
  Commit id: c1e47bad34ce1d9c84ed57c9b8978bcbd5a02e98
  Platform:
    osname=darwin
    osvers=13.4.0
    archname=darwin-thread-multi-2level
    uname='darwin isengard.local 13.4.0 darwin kernel version 13.4.0:
mon jan 11 18:17:34 pst 2016; root:xnu-2422.115.15~1release_x86_64
x86_64 '
    config_args='-de -Dusedevel -DDEBUGGING -Dusethreads'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -DPERL_USE_SAFE_PUTENV'
    optimize='-O3 -g'
    cppflags='-fno-common -DPERL_DARWIN -mmacosx-version-min=10.9
-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
    ccversion=''
    gccversion='4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -mmacosx-version-min=10.9 -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib
/usr/lib
    libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=
    so=dylib
    useshrplib=false
    libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=bundle
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags=' -mmacosx-version-min=10.9 -bundle -undefined
dynamic_lookup -L/usr/local/lib -fstack-protector'



@INC for perl 5.29.9:
    lib
    /usr/local/lib/perl5/site_perl/5.29.9/darwin-thread-multi-2level
    /usr/local/lib/perl5/site_perl/5.29.9
    /usr/local/lib/perl5/5.29.9/darwin-thread-multi-2level
    /usr/local/lib/perl5/5.29.9


Environment for perl 5.29.9:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/dur-randir
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/texbin
    PERLBREW_HOME=/Users/dur-randir/.perlbrew
    PERLBREW_MANPATH=/Users/dur-randir/perlbrew/perls/perl-5.22.1/man
    PERLBREW_PATH=/Users/dur-randir/perlbrew/bin:/Users/dur-randir/perlbrew/perls/perl-5.22.1/bin
    PERLBREW_PERL=perl-5.22.1
    PERLBREW_ROOT=/Users/dur-randir/perlbrew
    PERLBREW_SHELLRC_VERSION=0.84
    PERLBREW_VERSION=0.84
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/zsh

[p5pRT]

From @khwilliamson

Thanks, fixed by
commit 11b48e7
Author​: Karl Williamson <khw@​cpan.org>
Date​: Mon Apr 15 12​:05​:07 2019 -0600

  PATCH​: [perl #134029] Fail assert in pattern wildcard
 
  The failing pattern has a single character subpattern, which should be
  caught and compilation aborted, and this commit now does so.
--
Karl Williamson

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

@khwilliamson - Status changed from 'open' to 'resolved'